Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIAeO-0000dm-9f for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Feb 2022 14:42:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIAeM-0005Tt-JG for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Feb 2022 14:42:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIAeM-0005Tj-63 for pgsql-hackers@lists.postgresql.org; Thu, 10 Feb 2022 14:42:22 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIAeE-0003Co-UU for pgsql-hackers@postgresql.org; Thu, 10 Feb 2022 14:42:21 +0000 Received: from [192.168.11.9] (p2019072-ipbf2307funabasi.chiba.ocn.ne.jp [122.30.130.72]) by oss.nttdata.com (Postfix) with ESMTPSA id 77408604F2; Thu, 10 Feb 2022 23:42:11 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.5 at oss.nttdata.com Content-Type: multipart/mixed; boundary="------------JlCeBvaD2VIDDzAcwKDozjmp" Message-ID: <0fbc8eb3-f5b9-33ed-9cf2-dceef9a3658f@oss.nttdata.com> Date: Thu, 10 Feb 2022 23:42:11 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: Support escape sequence for cluster_name in postgres_fdw.application_name Content-Language: en-US To: "r.takahashi_2@fujitsu.com" , Kyotaro Horiguchi Cc: "pgsql-hackers@postgresql.org" References: <1041dc9a-c976-049f-9f14-e7d94c29c4b2@oss.nttdata.com> <20220127.171042.1194024926941192601.horikyota.ntt@gmail.com> <87a9be5a-ff59-47ff-ac7f-fad7891a46e3@oss.nttdata.com> From: Fujii Masao In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------JlCeBvaD2VIDDzAcwKDozjmp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2022/02/09 9:19, r.takahashi_2@fujitsu.com wrote: > Hi, > > > Thank you for updating the patch. > I agree with the documentation and program. > > How about adding the test for %c (Session ID)? > (Adding the test for %C (cluster_name) seems difficult.) Ok, I added the tests for %c and %C escape sequences. Attached is the updated version of the patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------JlCeBvaD2VIDDzAcwKDozjmp Content-Type: text/plain; charset=UTF-8; name="pgfdw_appname_cluster_name_v3.patch" Content-Disposition: attachment; filename="pgfdw_appname_cluster_name_v3.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L2V4cGVjdGVkL3Bvc3RncmVzX2Zk dy5vdXQgYi9jb250cmliL3Bvc3RncmVzX2Zkdy9leHBlY3RlZC9wb3N0Z3Jlc19mZHcub3V0 CmluZGV4IGIyZTAyY2FlZmUuLjA1NzM0MjA4M2MgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcG9z dGdyZXNfZmR3L2V4cGVjdGVkL3Bvc3RncmVzX2Zkdy5vdXQKKysrIGIvY29udHJpYi9wb3N0 Z3Jlc19mZHcvZXhwZWN0ZWQvcG9zdGdyZXNfZmR3Lm91dApAQCAtMTA5MTAsNiArMTA5MTAs MjYgQEAgU0VMRUNUIHBnX3Rlcm1pbmF0ZV9iYWNrZW5kKHBpZCwgMTgwMDAwKSBGUk9NIHBn X3N0YXRfYWN0aXZpdHkKICB0CiAoMSByb3cpCiAKKy0tIFRlc3QgJWMgKHNlc3Npb24gSUQp IGFuZCAlQyAoY2x1c3RlciBuYW1lKSBlc2NhcGUgc2VxdWVuY2VzLgorU0VUIHBvc3RncmVz X2Zkdy5hcHBsaWNhdGlvbl9uYW1lIFRPICdmZHdfJUMlYyc7CitTRUxFQ1QgMSBGUk9NIGZ0 NiBMSU1JVCAxOworID9jb2x1bW4/IAorLS0tLS0tLS0tLQorICAgICAgICAxCisoMSByb3cp CisKK1NFTEVDVCBwZ190ZXJtaW5hdGVfYmFja2VuZChwaWQsIDE4MDAwMCkgRlJPTSBwZ19z dGF0X2FjdGl2aXR5CisgIFdIRVJFIGFwcGxpY2F0aW9uX25hbWUgPQorICAgIHN1YnN0cmlu ZygnZmR3XycgfHwgY3VycmVudF9zZXR0aW5nKCdjbHVzdGVyX25hbWUnKSB8fAorICAgICAg dG9faGV4KHRydW5jKEVYVFJBQ1QoRVBPQ0ggRlJPTSAoU0VMRUNUIGJhY2tlbmRfc3RhcnQg RlJPTQorICAgICAgcGdfc3RhdF9nZXRfYWN0aXZpdHkocGdfYmFja2VuZF9waWQoKSkpKSk6 OmludGVnZXIpIHx8ICcuJyB8fAorICAgICAgdG9faGV4KHBnX2JhY2tlbmRfcGlkKCkpCisg ICAgICBmb3IgY3VycmVudF9zZXR0aW5nKCdtYXhfaWRlbnRpZmllcl9sZW5ndGgnKTo6aW50 KTsKKyBwZ190ZXJtaW5hdGVfYmFja2VuZCAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyB0 CisoMSByb3cpCisKIC0tQ2xlYW4gdXAKIFJFU0VUIHBvc3RncmVzX2Zkdy5hcHBsaWNhdGlv bl9uYW1lOwogUkVTRVQgZGVidWdfZGlzY2FyZF9jYWNoZXM7CmRpZmYgLS1naXQgYS9jb250 cmliL3Bvc3RncmVzX2Zkdy9vcHRpb24uYyBiL2NvbnRyaWIvcG9zdGdyZXNfZmR3L29wdGlv bi5jCmluZGV4IGZjM2NlNmE1M2EuLmFmMzhlOTU2ZTcgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIv cG9zdGdyZXNfZmR3L29wdGlvbi5jCisrKyBiL2NvbnRyaWIvcG9zdGdyZXNfZmR3L29wdGlv bi5jCkBAIC00ODksNiArNDg5LDEyIEBAIHByb2Nlc3NfcGdmZHdfYXBwbmFtZShjb25zdCBj aGFyICphcHBuYW1lKQogCQkJY2FzZSAnYSc6CiAJCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmlu ZygmYnVmLCBhcHBsaWNhdGlvbl9uYW1lKTsKIAkJCQlicmVhazsKKwkJCWNhc2UgJ2MnOgor CQkJCWFwcGVuZFN0cmluZ0luZm8oJmJ1ZiwgIiVseC4leCIsIChsb25nKSAoTXlTdGFydFRp bWUpLCBNeVByb2NQaWQpOworCQkJCWJyZWFrOworCQkJY2FzZSAnQyc6CisJCQkJYXBwZW5k U3RyaW5nSW5mb1N0cmluZygmYnVmLCBjbHVzdGVyX25hbWUpOworCQkJCWJyZWFrOwogCQkJ Y2FzZSAnZCc6CiAJCQkJYXBwZW5kU3RyaW5nSW5mb1N0cmluZygmYnVmLCBNeVByb2NQb3J0 LT5kYXRhYmFzZV9uYW1lKTsKIAkJCQlicmVhazsKZGlmZiAtLWdpdCBhL2NvbnRyaWIvcG9z dGdyZXNfZmR3L3NxbC9wb3N0Z3Jlc19mZHcuc3FsIGIvY29udHJpYi9wb3N0Z3Jlc19mZHcv c3FsL3Bvc3RncmVzX2Zkdy5zcWwKaW5kZXggZTA1MDYzOWI1Ny4uNmM5ZjU3OWM0MSAxMDA2 NDQKLS0tIGEvY29udHJpYi9wb3N0Z3Jlc19mZHcvc3FsL3Bvc3RncmVzX2Zkdy5zcWwKKysr IGIvY29udHJpYi9wb3N0Z3Jlc19mZHcvc3FsL3Bvc3RncmVzX2Zkdy5zcWwKQEAgLTM1MDEs NiArMzUwMSwxNyBAQCBTRUxFQ1QgcGdfdGVybWluYXRlX2JhY2tlbmQocGlkLCAxODAwMDAp IEZST00gcGdfc3RhdF9hY3Rpdml0eQogICAgIHN1YnN0cmluZygnZmR3XycgfHwgY3VycmVu dF9zZXR0aW5nKCdhcHBsaWNhdGlvbl9uYW1lJykgfHwKICAgICAgIENVUlJFTlRfVVNFUiB8 fCAnJScgZm9yIGN1cnJlbnRfc2V0dGluZygnbWF4X2lkZW50aWZpZXJfbGVuZ3RoJyk6Omlu dCk7CiAKKy0tIFRlc3QgJWMgKHNlc3Npb24gSUQpIGFuZCAlQyAoY2x1c3RlciBuYW1lKSBl c2NhcGUgc2VxdWVuY2VzLgorU0VUIHBvc3RncmVzX2Zkdy5hcHBsaWNhdGlvbl9uYW1lIFRP ICdmZHdfJUMlYyc7CitTRUxFQ1QgMSBGUk9NIGZ0NiBMSU1JVCAxOworU0VMRUNUIHBnX3Rl cm1pbmF0ZV9iYWNrZW5kKHBpZCwgMTgwMDAwKSBGUk9NIHBnX3N0YXRfYWN0aXZpdHkKKyAg V0hFUkUgYXBwbGljYXRpb25fbmFtZSA9CisgICAgc3Vic3RyaW5nKCdmZHdfJyB8fCBjdXJy ZW50X3NldHRpbmcoJ2NsdXN0ZXJfbmFtZScpIHx8CisgICAgICB0b19oZXgodHJ1bmMoRVhU UkFDVChFUE9DSCBGUk9NIChTRUxFQ1QgYmFja2VuZF9zdGFydCBGUk9NCisgICAgICBwZ19z dGF0X2dldF9hY3Rpdml0eShwZ19iYWNrZW5kX3BpZCgpKSkpKTo6aW50ZWdlcikgfHwgJy4n IHx8CisgICAgICB0b19oZXgocGdfYmFja2VuZF9waWQoKSkKKyAgICAgIGZvciBjdXJyZW50 X3NldHRpbmcoJ21heF9pZGVudGlmaWVyX2xlbmd0aCcpOjppbnQpOworCiAtLUNsZWFuIHVw CiBSRVNFVCBwb3N0Z3Jlc19mZHcuYXBwbGljYXRpb25fbmFtZTsKIFJFU0VUIGRlYnVnX2Rp c2NhcmRfY2FjaGVzOwpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3Bvc3RncmVzLWZkdy5z Z21sIGIvZG9jL3NyYy9zZ21sL3Bvc3RncmVzLWZkdy5zZ21sCmluZGV4IDJiYjMxZjExMjUu LjE3Y2Q5MGFiMTIgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9wb3N0Z3Jlcy1mZHcuc2dt bAorKysgYi9kb2Mvc3JjL3NnbWwvcG9zdGdyZXMtZmR3LnNnbWwKQEAgLTk4Myw2ICs5ODMs MjAgQEAgcG9zdGdyZXM9IyBTRUxFQ1QgcG9zdGdyZXNfZmR3X2Rpc2Nvbm5lY3RfYWxsKCk7 CiAgICAgICAgICA8ZW50cnk+PGxpdGVyYWw+JWE8L2xpdGVyYWw+PC9lbnRyeT4KICAgICAg ICAgIDxlbnRyeT5BcHBsaWNhdGlvbiBuYW1lIG9uIGxvY2FsIHNlcnZlcjwvZW50cnk+CiAg ICAgICAgIDwvcm93PgorICAgICAgICA8cm93PgorICAgICAgICAgPGVudHJ5PjxsaXRlcmFs PiVjPC9saXRlcmFsPjwvZW50cnk+CisgICAgICAgICA8ZW50cnk+CisgICAgICAgICAgU2Vz c2lvbiBJRCBvbiBsb2NhbCBzZXJ2ZXIKKyAgICAgICAgICAoc2VlIDx4cmVmIGxpbmtlbmQ9 Imd1Yy1sb2ctbGluZS1wcmVmaXgiLz4gZm9yIGRldGFpbHMpCisgICAgICAgICA8L2VudHJ5 PgorICAgICAgICA8L3Jvdz4KKyAgICAgICAgPHJvdz4KKyAgICAgICAgIDxlbnRyeT48bGl0 ZXJhbD4lQzwvbGl0ZXJhbD48L2VudHJ5PgorICAgICAgICAgPGVudHJ5PgorICAgICAgICAg IENsdXN0ZXIgbmFtZSBpbiBsb2NhbCBzZXJ2ZXIKKyAgICAgICAgICAoc2VlIDx4cmVmIGxp bmtlbmQ9Imd1Yy1jbHVzdGVyLW5hbWUiLz4gZm9yIGRldGFpbHMpCisgICAgICAgICA8L2Vu dHJ5PgorICAgICAgICA8L3Jvdz4KICAgICAgICAgPHJvdz4KICAgICAgICAgIDxlbnRyeT48 bGl0ZXJhbD4ldTwvbGl0ZXJhbD48L2VudHJ5PgogICAgICAgICAgPGVudHJ5PlVzZXIgbmFt ZSBvbiBsb2NhbCBzZXJ2ZXI8L2VudHJ5PgpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvdXRp bHMvZ3VjLmggYi9zcmMvaW5jbHVkZS91dGlscy9ndWMuaAppbmRleCA2YmI4MTcwN2IwLi5m MWJmZTc5ZmViIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS91dGlscy9ndWMuaAorKysgYi9z cmMvaW5jbHVkZS91dGlscy9ndWMuaApAQCAtMjcxLDcgKzI3MSw3IEBAIGV4dGVybiBpbnQJ dGVtcF9maWxlX2xpbWl0OwogCiBleHRlcm4gaW50CW51bV90ZW1wX2J1ZmZlcnM7CiAKLWV4 dGVybiBjaGFyICpjbHVzdGVyX25hbWU7CitleHRlcm4gUEdETExJTVBPUlQgY2hhciAqY2x1 c3Rlcl9uYW1lOwogZXh0ZXJuIFBHRExMSU1QT1JUIGNoYXIgKkNvbmZpZ0ZpbGVOYW1lOwog ZXh0ZXJuIGNoYXIgKkhiYUZpbGVOYW1lOwogZXh0ZXJuIGNoYXIgKklkZW50RmlsZU5hbWU7 Cg== --------------JlCeBvaD2VIDDzAcwKDozjmp--