Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Ppw-0003MF-P3 for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 02:36:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l2Ppv-0005WZ-Mp for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Jan 2021 02:36:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2Ppv-0005WR-Fb for pgsql-hackers@lists.postgresql.org; Thu, 21 Jan 2021 02:36:39 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l2Pps-0007ec-5N for pgsql-hackers@postgresql.org; Thu, 21 Jan 2021 02:36:38 +0000 Received: by mail-ej1-x62c.google.com with SMTP id g3so509570ejb.6 for ; Wed, 20 Jan 2021 18:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lVuF2Vm2U8j1aYOCVgmJ6uMkjW8YTYpydkZy67/wn5I=; b=LUqg8Acra9tminp2TzS0hNDbvgaoR6ebfb6MoF9vWlpY/1n/sRJBtr8qPmxmi4aiqH OIRVUo6hyQGy1bIf25nbt0baeAb2QyuWUQsQg1u2pnG02A8CG7z+wcYaY3riTB5ZIjnb O+SXjyIuPKxpTIegn/+1WVxllzN9Vzz2RrOlYrnR6vyUddrI9vgs1xdCzYzGBbwoaIq/ ANZQvkhEpZ8pyBz+EahdqgvkME5YhcTfwjrr4ZTrkDg+W9Rj6pFYa9wVUeR/hW7/LTxM hoO5gMqaVH2uLXRWxdFeOoXy50G2O3+UY1Y+7o8PbA5jOy1KLK1oHd8xNHJNn0oLrNeE ZDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lVuF2Vm2U8j1aYOCVgmJ6uMkjW8YTYpydkZy67/wn5I=; b=TDwKSxrNUte/+7P4olyVmHcthyhY4PEYRfTIzv0HcxoZxMKOoP8pgXW0x8BmAIh0Om K4C5KvHzAz5oslc6A+FfHCu/P6Zz7C9KUCKql5JkI37MhB+XMNn68CcKCjJ0SpKzAZqT KgQBD61uQeMEn3Uby/Aknmo6qA0nAuCTYdO2G4EEEFVIDzxodHMfybz5b56MIApT2t+1 BO2LkTiFlirqFzdBjQMudHwkzETSVRWLEd9Fd5ENztPEl8Bi5fRmIP9sjqc3BSoNb57v cUKKVeZ9xi9HldN3Uh3rU8g2JQqbEL7L10ycVgcWM/7zuwULQI648zuMyi5yyRbYlPfU E0rQ== X-Gm-Message-State: AOAM532eYUvSIcDwaeuacTLCQentAMn+E1iMo6GC4gJwtv7dMDvkVgbe FtmQ4t3BWlXZmvTuHZ1V73EaqSqEfUXoflAW7EKyhX/HO5YRrYteL2BxmVBtUkFu4y344FATUES kyOJ8cZkJLgttMJMx9OspIzH6RfRaCok7xOxKhifj6Z+LEQrgbrsF+fH7hwIZokJ/1uuYFaX9Cv uEXXPC8yXKCel2BgDS7PFjl3/ltIrz3++5zWGinIVHJKUtQMe9L3h/y9FVSBo7MpILbS5L5Z+eo MjI2OJcdzpvxMDkIa7e+b5kLyh6eyV9LIgMkg== X-Google-Smtp-Source: ABdhPJwrVL9WbHVApiv96WrDQ8cDEvSQ/rrPWBpaKrorRF+QkuL7gHNWUbp4Ax3W92orh9NqPFmGag== X-Received: by 2002:a17:906:a84d:: with SMTP id dx13mr7802874ejb.275.1611196594739; Wed, 20 Jan 2021 18:36:34 -0800 (PST) Received: from [10.137.0.20] (ip-86-49-253-127.net.upcbroadband.cz. [86.49.253.127]) by smtp.gmail.com with ESMTPSA id l17sm1605731ejn.122.2021.01.20.18.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 18:36:34 -0800 (PST) Subject: Re: POC: postgres_fdw insert batching To: "tsunakawa.takay@fujitsu.com" , Amit Langote Cc: Zhihong Yu , "Andrey V. Lepikhov" , Tomas Vondra , "pgsql-hackers@postgresql.org" References: <20200628151002.7x5laxwpgvkyiu3q@development> <9d94c863-ce7c-ea7f-6b84-834c98929e2f@enterprisedb.com> <7e70a11e-cf5d-2e5f-a802-274c5e0e236b@enterprisedb.com> <3ca9496f-0827-bf21-b709-593de63440a5@enterprisedb.com> <4faa3d09-0fc8-c4d6-7aec-87428fabd161@enterprisedb.com> From: Tomas Vondra Message-ID: <0fc809f6-7c3c-6d06-7ea3-f10765dfdf08@enterprisedb.com> Date: Thu, 21 Jan 2021 03:36:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/21/21 3:09 AM, tsunakawa.takay@fujitsu.com wrote: > From: Tomas Vondra >> Right, that's pretty much what I ended up doing (without the CMD_INSERT >> check it'd add batching info to explain for updates too, for example). >> I'll do a bit more testing on the attached patch, but I think that's the right fix to >> push. > > Thanks to the outer check for operation == CMD_INSERT, the inner one became unnecessary. > Right. I've pushed the fix, hopefully buildfarm will get happy again. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company