Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZFFh-00HIEy-VY for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Jul 2024 19:44:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sZFFf-00Ci3y-HM for pgsql-hackers@arkaria.postgresql.org; Wed, 31 Jul 2024 19:44:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZFFf-00Ci3q-3n for pgsql-hackers@lists.postgresql.org; Wed, 31 Jul 2024 19:44:47 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sZFFc-002QZy-ET for pgsql-hackers@postgresql.org; Wed, 31 Jul 2024 19:44:45 +0000 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-2cb56c2c30eso1001578a91.1 for ; Wed, 31 Jul 2024 12:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1722455083; x=1723059883; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=b4KTiQL6Qwvoyx9olIINEqS0zVLW8evasPAjwbVv/hY=; b=z0ZwKDJgCaqSzHPoR7kx7QGdQU1WNSK/5Ts/6Xg9e1ltap/tutQ9adbsN1nhOTP4Ir bsvw0kocqJXhOio3VyrEwqL7NhDptDOlT6Px4UOXoqjnzfhGM4oEQevsFRfg5aLz/z2y wQr7HkaKBt6forn002xAM3C/V+lJ39vS5Rkcr+NQP4r2Uu5/RXGew/zNXKwkTpPm5ftd M2/iAb66UILBCi5MqJ74wzAsE7nPY63p1j8Rv8DBguFgAdTAqkpfJ0EB9sKubdkTUYdP 7ndfMMoGhyZ0uTqR62UatHNsq6U2v6cQopLjbyLBY6lUNaJKLfqnkFEkW0ShEXOiXGlm VXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722455083; x=1723059883; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b4KTiQL6Qwvoyx9olIINEqS0zVLW8evasPAjwbVv/hY=; b=RDIGcNbyypQcsAWqHFDjUBW8FfqDonpAoTwCymLk56CD1ywoITvT7kjCjn/3zNFMb0 +2s/jCjPPv6cRUfQw+yWrbib8uuQ6GC0fayni57sjWGI8Y95QV3uIiV8VPY9A2tTivNB JtiVP5KUtKEBpxSWeOAtr2rZRZgtyN50EhIXCUCH312+1cieTCvyiKWJPR5NAVY3cBek watYoHro2rg8XIF5xlkKVhcTTnD+OQZu3UUduP8TSUOT2xvoCc66ZBDjdgMmklCquh2T ZsSvznynbkzoa9S7ynbGw+8tfDDoLLNuhk35z+cUvUHKT9YXSkekZKT3e53RQPCNugpK UJPg== X-Forwarded-Encrypted: i=1; AJvYcCXxJUpvsEqJ20vEf7z7GPRkRrC9OHbJkoe02Cn3j3Mg60fkpRXLDl1hPjzfm6zcY5vc2/z0ol+fTj2kYDqKZXiARxrn6RdM5W92hyar X-Gm-Message-State: AOJu0YzCkHkwv6lCoVIZCeOmT/P1Tc7ulr9P2RzlhKGRLnnh8hz3DvD5 VShnkD1X0Q0onX5VfbmJYgoxshF2sGxI7q5UdUCM5eV7vYIeFtDg/vDK1vcMCg== X-Google-Smtp-Source: AGHT+IEnmd6mRBkAeYTtpeA21B/Jm1gVUP8SaEwjSnhyzM0L7VQianyG+chvJya+c4FyhJu1AMEvUQ== X-Received: by 2002:a17:90b:4c47:b0:2c9:7343:71f1 with SMTP id 98e67ed59e1d1-2cfe81d695amr314941a91.14.1722455083413; Wed, 31 Jul 2024 12:44:43 -0700 (PDT) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cfdc488d72sm1756069a91.30.2024.07.31.12.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 12:44:42 -0700 (PDT) Message-ID: <0fd7830bee2cfba7697f7eaec07bb664df3c1687.camel@j-davis.com> Subject: Re: [17+] check after second call to pg_strnxfrm is too strict, relax it From: Jeff Davis To: Heikki Linnakangas , pgsql-hackers@postgresql.org Date: Wed, 31 Jul 2024 12:44:36 -0700 In-Reply-To: <81450d84-889d-41f8-8583-5416ddd076a7@iki.fi> References: <32f85d88d1f64395abfe5a10dd97a62a4d3474ce.camel@j-davis.com> <81450d84-889d-41f8-8583-5416ddd076a7@iki.fi> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, 2024-07-30 at 23:01 +0300, Heikki Linnakangas wrote: > +1. A comment in the pg_strnxfrm() function itself would be good too. Committed, thank you. Backported to 16 (original email said 17, but that was a mistake). Regards, Jeff Davis