Feedback-ID: ie0a040ee:Fastmail
Message-ID: <0fd7f15c-ac65-4e0b-93b7-fd0eb5df1dcf@eisentraut.org>
Date: Wed, 8 Nov 2023 08:31:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
Content-Language: en-US
To: Nazir Bilal Yavuz <byavuz81@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <CAN55FZ3o52jRfEn=NEVRV4OxsWO4v-urtS-ADZwfoe=AT5PPCg@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAN55FZ3o52jRfEn=NEVRV4OxsWO4v-urtS-ADZwfoe=AT5PPCg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/0fd7f15c-ac65-4e0b-93b7-fd0eb5df1dcf%40eisentraut.org>
Precedence: bulk

On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> There are multiple 'always:' keywords under the CompilerWarnings task.
> Instead of that, we can use one 'always:' and move the instructions
> under this. So, I removed unnecessary ones and rearranged indents
> according to that change.

I'm not sure this change is beneficial.  The way the code is currently 
arranged, it's a bit easier to move or change individual blocks, and 
it's also easier to read the file, because the "always:" is next to each 
"script" and doesn't scroll off the screen.