From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
cc: Aleksander Alekseev <aleksander@tigerdata.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Chao Li <li.evan.chao@gmail.com>,
        Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>,
        Bruce Momjian <bruce@momjian.us>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
In-reply-to: <202512121547.dwkzxcs56227@alvherre.pgsql>
References: <202512121547.dwkzxcs56227@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
	message dated "Fri, 12 Dec 2025 16:53:39 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1000973.1765556221.1@sss.pgh.pa.us>
Date: Fri, 12 Dec 2025 11:17:01 -0500
Message-ID: <1000974.1765556221@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1000974.1765556221%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> It's strange to see this thread go on about messing with the Perl script
> because we're too afraid of pg_bsd_indent.  Maybe we should take
> ownership of that code -- improve its own indentation to our
> conventions, add comments, rename unclear variables, and so on until we
> have something we can work with, and fix these weird bugs and
> idiosincratic behaviors we don't like.  I just found out this code dates
> back from 1976.

I've worked with that code a little bit, and it's mostly unreadable
spaghetti :-(.  If somebody wants to make an effort to make it not
so awful, that'd be great, but I fear it's a very nontrivial project.

Having said that, we've already basically forked it from the NetBSD
upstream, so there is no reason not to diverge further.

> We have a _huge_ regression test for it: our own source code repository.
> It's not like any breakage is going to go unnoticed.

True.

			regards, tom lane