Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fq47d-0000z2-Rr for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Aug 2018 22:18:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fq47b-0006AO-Of for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Aug 2018 22:18:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fq47b-0006AB-Hr for pgsql-hackers@lists.postgresql.org; Wed, 15 Aug 2018 22:18:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fq47X-0005YW-QX for pgsql-hackers@lists.postgresql.org; Wed, 15 Aug 2018 22:18:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w7FMIL89010085; Wed, 15 Aug 2018 18:18:21 -0400 From: Tom Lane To: Andres Freund cc: Alvaro Herrera , Robert Haas , PostgreSQL Hackers Subject: Re: C99 compliance for src/port/snprintf.c In-reply-to: <20180815215217.b3gnglunnxpxsl2d@alap3.anarazel.de> References: <20180815155643.zx4qpcmpvhemefyg@alvherre.pgsql> <13169.1534352739@sss.pgh.pa.us> <17490.1534356329@sss.pgh.pa.us> <20180815215217.b3gnglunnxpxsl2d@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 15 Aug 2018 14:52:17 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10083.1534371501.1@sss.pgh.pa.us> Date: Wed, 15 Aug 2018 18:18:21 -0400 Message-ID: <10084.1534371501@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > On 2018-08-15 14:05:29 -0400, Tom Lane wrote: >> Still want to argue for no backpatch? > I'm a bit confused. Why did you just backpatch this ~two hours after > people objected to the idea? Even if it were during my current work > hours, I don't even read mail that often if I'm hacking on something > complicated. If a consensus emerges to deal with this some other way, reverting isn't hard. But I think it's pretty clear at this point that we're dealing with real bugs versus entirely hypothetical bugs, and that's not a decision that's hard to make IMO. regards, tom lane