Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOo4H-0007Yg-3S for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Mar 2021 20:56:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOo4G-0006vV-1E for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Mar 2021 20:56:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOo4F-0006vO-Qj for pgsql-hackers@lists.postgresql.org; Tue, 23 Mar 2021 20:55:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOo4D-0006PB-NK for pgsql-hackers@postgresql.org; Tue, 23 Mar 2021 20:55:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 12NKtock1010643; Tue, 23 Mar 2021 16:55:50 -0400 From: Tom Lane To: Jan Wieck cc: Bruce Momjian , Zhihong Yu , Andrew Dunstan , Magnus Hagander , Robins Tharakan , Peter Eisentraut , "pgsql-hackers@postgresql.org" Subject: Re: pg_upgrade failing for 200+ million Large Objects In-reply-to: <872315a8-99fc-da4e-463d-784cfb5a025d@wi3ck.info> References: <181907.1616253799@sss.pgh.pa.us> <147fa478-510b-18ef-5323-9c1725b2493c@wi3ck.info> <5bdcb010-ecdd-c69a-b441-68002fc38483@wi3ck.info> <3886649c-c77d-dfd7-08a4-d1606bc71254@wi3ck.info> <91ccdb0d-42fd-7413-4e7c-3d6445655d2e@wi3ck.info> <20210323145628.GD579@momjian.us> <8d8d3961-8e8b-3dbe-f911-6f418c5fb1d3@wi3ck.info> <20210323180646.GG579@momjian.us> <91b02dc1-f0d9-e50d-849c-18d9a66484fb@wi3ck.info> <985941.1616524546@sss.pgh.pa.us> <986904.1616525964@sss.pgh.pa.us> <6cccaa33-c263-b8a2-b064-985605d33d25@wi3ck.info> <988415.1616528159@sss.pgh.pa.us> <872315a8-99fc-da4e-463d-784cfb5a025d@wi3ck.info> Comments: In-reply-to Jan Wieck message dated "Tue, 23 Mar 2021 15:59:48 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1010641.1616532950.1@sss.pgh.pa.us> Date: Tue, 23 Mar 2021 16:55:50 -0400 Message-ID: <1010642.1616532950@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jan Wieck writes: > Have we even reached a consensus yet on that doing it the way, my patch > is proposing, is the right way to go? Like that emitting BLOB TOC > entries into SECTION_DATA when in binary upgrade mode is a good thing? > Or that bunching all the SQL statements for creating the blob, changing > the ACL and COMMENT and SECLABEL all in one multi-statement-query is. Now you're asking for actual review effort, which is a little hard to come by towards the tail end of the last CF of a cycle. I'm interested in this topic, but I can't justify spending much time on it right now. regards, tom lane