Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYwj1-0005fE-GP for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Mar 2022 21:16:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nYwiz-0001WE-Lm for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Mar 2022 21:16:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYwiz-0001W4-CI for pgsql-hackers@lists.postgresql.org; Mon, 28 Mar 2022 21:16:29 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYwis-0006qO-Os for pgsql-hackers@postgresql.org; Mon, 28 Mar 2022 21:16:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22SLGEfu1011910; Mon, 28 Mar 2022 17:16:14 -0400 From: Tom Lane To: Mark Dilger cc: Andrew Dunstan , Peter Eisentraut , Joshua Brindle , Robert Haas , Jeff Davis , PostgreSQL-development , Joe Conway Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs In-reply-to: <18A291A8-362E-4AB1-833D-66410751E401@enterprisedb.com> References: <3D691E20-C1D5-4B80-8BA5-6BEB63AF3029@enterprisedb.com> <2D6C1081-DB7D-4260-8987-5B4912E95917@enterprisedb.com> <1A6DA47B-2D5F-427E-AD72-1D8BD23BF94C@enterprisedb.com> <79685.1646604824@sss.pgh.pa.us> <83814.1646607430@sss.pgh.pa.us> <78889A65-CA7A-4015-866D-33460967071D@enterprisedb.com> <92485.1646609263@sss.pgh.pa.us> <43857434-3f9b-3! 66f-0401-7aea558827e1@dunslane.net> <664799.1647456444@sss.pgh.pa.us> <771410.1647528423@sss.pgh.pa.us> <9b37fa41-a068-81! ! 66-78c3-4503a867de07@dunslane.net> <895087.1648494675@sss.pgh.pa.us> <18A291A8-362E-4AB1-833D-66410751E401@enterprisedb.com> Comments: In-reply-to Mark Dilger message dated "Mon, 28 Mar 2022 13:57:50 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1011908.1648502174.1@sss.pgh.pa.us> Date: Mon, 28 Mar 2022 17:16:14 -0400 Message-ID: <1011909.1648502174@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I just came across something odd in v12 that is still there in v13: ExecGrant_Parameter uses InvokeObjectPostAlterHook not InvokeObjectPostAlterHookArgStr. This seems pretty inconsistent. Is there a good argument for it? ... or, for that matter, why is there any such call at all? No other GRANT/REVOKE operation calls such a hook. regards, tom lane