From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Regina Obe" <lr@pcorp.us>
cc: "'Gregory Stark \(as CFM\)'" <stark.cfm@gmail.com>,
        "'Sandro Santilli'" <strk@kbt.io>, pgsql-hackers@lists.postgresql.org,
        "'Regina Obe'" <r@pcorp.us>
Subject: Re: Ability to reference other extensions by schema in extension scripts
In-reply-to: <004b01d95394$16123ee0$4236bca0$@pcorp.us>
References: <003001d8f4ae$402282c0$c0678840$@pcorp.us> <000401d94bc8$48dff700$da9fe500$@pcorp.us> <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org> <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com> <005401d95083$26ca24a0$745e6de0$@pcorp.us> <995823.1678478825@sss.pgh.pa.us> <004b01d95394$16123ee0$4236bca0$@pcorp.us>
Comments: In-reply-to "Regina Obe" <lr@pcorp.us>
	message dated "Fri, 10 Mar 2023 16:05:46 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1012974.1678486476.1@sss.pgh.pa.us>
Date: Fri, 10 Mar 2023 17:14:36 -0500
Message-ID: <1012975.1678486476@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1012975.1678486476%40sss.pgh.pa.us>
Precedence: bulk

"Regina Obe" <lr@pcorp.us> writes:
>> If you want to work harder, perhaps a reasonable way to deal with the issue
>> would be to allow dependent extensions to declare that they don't want your
>> extension relocated.  But I do not think it's okay to make that the default
>> behavior, much less the only behavior.

> -  the main issue I ran into is I have to introduce another dependency type
> or go with Sandro's idea of using refsubobjid for this purpose.

No, pg_depend is not the thing to use for this.  I was thinking of a new
field in the extension's control file, right beside where it says it's
dependent on such-and-such extensions in the first place.  Say like

	requires = 'extfoo, extbar'
	no_relocate = 'extfoo'

> So you are proposing I change the execute_extension_scripts input args to
> take more args?

Why not?  It's local to that file, so you won't break anything.

			regards, tom lane