public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ronan Dunklau <[email protected]>
To: Tom Lane <[email protected]>
To: [email protected]
Cc: Pgsql Hackers <[email protected]>
Cc: Paul Jungwirth <[email protected]>
Subject: Re: Exclusion constraints on partitioned tables
Date: Tue, 24 Jan 2023 15:38:13 +0100
Message-ID: <10212835.nUPlyArG6x@aivenlaptop> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

Le vendredi 16 décembre 2022, 06:11:49 CET Paul Jungwirth a écrit :
> On 12/15/22 16:12, Tom Lane wrote:
> >> This patch also requires the matching constraint columns to use equality
> >> comparisons (`(foo WITH =)`), so it is really equivalent to the existing
> >> b-tree rule.
> > 
> > That's not quite good enough: you'd better enforce that it's the same
> > equality operator (and same collation, if relevant) as is being used
> > in the partition key.
> > [snip]
> > It might work better to consider the operator itself and ask if
> > it's equality in the same btree opfamily that's used by the
> > partition key.
> 
> Thank you for taking a look! Here is a comparison on just the operator
> itself.
> 

I've taken a look at the patch, and I'm not sure why you keep the restriction 
on the Gist operator being of the RTEqualStrategyNumber strategy. I don't 
think  we have any other place where we expect those strategy numbers to 
match. For hash it's different, as the hash-equality is the only operator 
strategy and as such there is no other way to look at it. Can't we just 
enforce partition_operator == exclusion_operator without adding the 
RTEqualStrategyNumber for the opfamily into the mix ?

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Exclusion constraints on partitioned tables
  In-Reply-To: <10212835.nUPlyArG6x@aivenlaptop>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox