From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
cc: Andreas Karlsson <andreas@proxel.se>, pgsql-hackers@lists.postgresql.org
Subject: Re: Commitfest app release on Feb 17 with many improvements
In-reply-to: 
 <CAGECzQQ-hg4P-Oq+4-027dEsUNB6MqSU2aNAkBcbHTaiYSY-KQ@mail.gmail.com>
References: 
 <CAGECzQTbHhaZMY-=Y=OGMU_jik4MqCfsc7rDf6AnT=Aq-B6cZA@mail.gmail.com>
 <CALDaNm3ta7UV_eD+ObgVsivGgPZSj1YqnO4-ojeBz10J95u7_A@mail.gmail.com>
 <CAGECzQSE7igwsTUk17i+RNEUL1zR-Zkp-1Zs7KkhmBxAu_Fksw@mail.gmail.com>
 <703819.1741281033@sss.pgh.pa.us>
 <CAGECzQRymvgXB9coGuGe7JY_qKWO2hcgVXDETrMEGOSfzKsTvg@mail.gmail.com>
 <CAGECzQQ+ZxgJaCb3w+hKbcZfwZwZ=-_0G8_06xZA5AF3c0mn8A@mail.gmail.com>
 <a61badfa-f6f2-4467-9dbf-bd8deddd9fb9@proxel.se>
 <CAGECzQQ-hg4P-Oq+4-027dEsUNB6MqSU2aNAkBcbHTaiYSY-KQ@mail.gmail.com>
Comments: In-reply-to Jelte Fennema-Nio <postgres@jeltef.nl>
	message dated "Fri, 07 Mar 2025 11:49:23 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1024102.1741365755.1@sss.pgh.pa.us>
Date: Fri, 07 Mar 2025 11:42:35 -0500
Message-ID: <1024103.1741365755@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1024103.1741365755%40sss.pgh.pa.us>
Precedence: bulk

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> On Fri, 7 Mar 2025 at 11:26, Andreas Karlsson <andreas@proxel.se> wrote:
>> Out of curiosity: do you track which method works? I would expect
>> everything to be applied with either git am or patch which can be
>> applied with git apply making git apply technically unnecessary.

> I think we need all of them...
> - git apply is unable to apply the patch in 5272 on top of main
> - git am, works with that 5272, but cannot apply any patch not created
> by git format-patch (for instance 5522)
> - I've been unable to get patch(1) not to return a failure if the
> patch is already applied. So applying e.g. 5522 twice. git apply
> handles that fine.

Hm, don't you *want* a failure if the patch is already applied?

			regards, tom lane