Subject: Re: LogicalChanges* and LogicalSubxact* wait events are never
 reported
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <ff077840-3ab2-04dd-bbe4-4f5dfd2ad481@oss.nttdata.com>
 <YW+nFebbUI9/LuLw@paquier.xyz>
 <CAA4eK1LNBQtcywY7-YHKBuLV3TfGn8E_uAXMDDi9j4TE0O0Bww@mail.gmail.com>
 <3d68e948-e1ae-bb27-94da-43863ec3ace3@oss.nttdata.com>
 <CAA4eK1LDaev5zVSav7PvaYBbNeK1sPA4XcxCCpfsd8HkUxa6Xg@mail.gmail.com>
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Message-ID: <102b9e3c-fa5f-9807-e817-6e9e55fdaff6@oss.nttdata.com>
Date: Fri, 22 Oct 2021 09:38:57 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: 
 <CAA4eK1LDaev5zVSav7PvaYBbNeK1sPA4XcxCCpfsd8HkUxa6Xg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/102b9e3c-fa5f-9807-e817-6e9e55fdaff6%40oss.nttdata.com>
Precedence: bulk


On 2021/10/21 17:40, Amit Kapila wrote:
> On Wed, Oct 20, 2021 at 3:46 PM Masahiro Ikeda <ikedamsh@oss.nttdata.com> wrote:
>>
>> On 2021/10/20 18:17, Amit Kapila wrote:
>>> On Wed, Oct 20, 2021 at 10:50 AM Michael Paquier <michael@paquier.xyz> wrote:
>>>>
>>>> On Wed, Oct 20, 2021 at 02:12:20PM +0900, Masahiro Ikeda wrote:
>>>>> If my understanding is right, it's better to remove them since they make
>>>>> users confused. Please see the attached patch. I confirmed that to make
>>>>> check-world passes all tests.
>>>>
>>>> Yeah, I don't see the point in keeping these events around if they are
>>>> not used.  Perhaps Amit has some plans for them, though.
>>>>
>>>
>>> No, there is no plan for these. As far as I remember, during
>>> development, we have decided to use BufFile interface and forgot to
>>> remove these events which were required by the previous versions of
>>> the patch. I'll take care of this.
>>>
>>> Thanks for the report and patch!
>> Thanks for your replies and for handling it!
>>
> 
> Pushed!

Thanks!

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION