Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x9k26-00000002CRe-0Jhr for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Sep 2026 14:02:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1x9k23-0000000CMq2-2ZXa for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Sep 2026 14:02:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x9k23-0000000CMpu-0ypt for pgsql-hackers@lists.postgresql.org; Thu, 24 Sep 2026 14:02:39 +0000 Received: from mail-wr2-x10.google.com ([2a00:1450:4864:30::10]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1x9k20-000000012Wy-2IHb for pgsql-hackers@lists.postgresql.org; Thu, 24 Sep 2026 14:02:38 +0000 Received: by mail-wr2-x10.google.com with SMTP id ffacd0b85a97d-482f63546c3so1698916f8f.1 for ; Thu, 24 Sep 2026 07:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1790258555; x=1790863355; darn=lists.postgresql.org; h=message-id:date:content-transfer-encoding:content-id:content-type :mime-version:comments:references:in-reply-to:subject:cc:to:from :from:to:cc:subject:date:message-id:reply-to:content-type; bh=W1YNOecKGQAkaaZ5hlZA96VjrI9aArnq5pOnbtdYklU=; b=ejZrTnmWxBO7VmS7cNAjOjNe+7m2UJDsMJPhFhUYTmA3UIn6yZmTNZ3Mp5ipgMmmld CB8a8kGle+1SXqqgmBpEvfEnylolZSSO9gIAMDL+5mUyJpfWDzr/Zr87Ep1UHJDnXarp 3wKmP9S9vA7UN5vZ0CNkeC19GSP6vWTKkTl00iJL8t6eIWS/pjUThGA7YjOz6ktqOEu9 y4f7HzO0qncEEz5/mLsX/+hPR6Lu6ojLM8k1JbgLL6cudAZ2IVuJhC6H2SEbdrcV3rEo S5Oqdcapir08w3Bs3yuC1MbVfM5fopb8uhkrayzkRhZ+cObIABWN/myr1nsb1SH35MZN E5lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790258555; x=1790863355; h=message-id:date:content-transfer-encoding:content-id:content-type :mime-version:comments:references:in-reply-to:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=W1YNOecKGQAkaaZ5hlZA96VjrI9aArnq5pOnbtdYklU=; b=vFBaW2fY/aI79OUgXuT4j11VWsfg9OjFcg6S9lr7IeUYrOu0ysnyi+GbVXbKjIS73+ 5mhQcWFdWG0t6SABXgEdV4QvXcOOLMaU8j+z8mfj+rgNh8NxCCgxTFG04gbq1hCoZMvQ baUvxynnGc/CngPRnfF7508eTTz+hUXVIJ/SGlFOJ+wa7tH/rRLZCmcdJ1MPW0UyX6H6 Q78/eVzVGJCRCCnB/i7SLZ/cuUmoCvXLsiKmhyFvPOX+t7juLdHCadb9PyoiRy0TG7Dj UqDBOTLjQ1L4Og5v05mk2o8NbVbJRZbzSyK4bCWCCMxfYakHyIQV2dC73Btc/EKThSQq rHzQ== X-Forwarded-Encrypted: i=1; AKwUvBxPYTEBr4Jg2OlZdQgdFI4QnzZLCZ2BVn0d7JgvVci+8G+FKWPUfwz7yErt1houLQPdcfeZf3aWvSyeqc/B@lists.postgresql.org X-Gm-Message-State: AFuF++niT/B9JVl5EfU40JHmkR3Q48/dnEhLDL+kVhhLjkdXq70xcJ5X xHp4EYQ4+iW+k45XOfB4ikLLkL6MAOoscxLc1y2LjVVY88goQHXwc2PZDsa0w7icctw= X-Gm-Gg: AYBFou0jxLxLD67JbBEoRb9FcEO9aJaaedHXhkERQlQnnP6tPLjFCDPQJCnrjwoqrhu m1Rhnft7R7An5wgS/lEOEWX4gwyCZi9UUarv8NWt9jSdZOmxtItDJ+rbyQuZCV+wtFFpa2rTqQW KW6vKpWSZc/OtsCTCBymHPRHMlHfVWr4S5eHZq2AqTmvQao83GTRWHNNknQc2o2Tcm8Xspb5TeT xFiyAzd/fEBCUElTZE7kPrehJftPWxviWLzXyYOY+JRnbtF7kZqcnxqayqUxdaWQ0T8PSxLCTdT UMgJ9mVTJgYzego2FFRoXUtuVLpmzjVyNUfRz4kK3Pv9Jv/CN7/d7YyFkFcfpXwjvQKluKLbxx9 /RIlQrulaPoYWrAoKFXt68UCTf9A/osnwv51WCaYWdnIhrsbkFShHQDeMUFnpXUs3rfg6z+Fhks lCZCxVc1sy1fkSYZaXSZuyq70d9fyXYeDytDb6Au8hQP0YXUZDZuVVxuEBXcktkus9Hnwfsp3pr Jga4IvvNQ== X-Received: by 2002:a05:6000:1887:b0:487:b00:3853 with SMTP id ffacd0b85a97d-4887175fc07mr4640962f8f.27.1790258555544; Thu, 24 Sep 2026 07:02:35 -0700 (PDT) Received: from localhost (109-81-170-16.rct.o2.cz. [109.81.170.16]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-488682676c7sm14229732f8f.3.2026.09.24.07.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 07:02:35 -0700 (PDT) From: Antonin Houska To: shihao zhong cc: Manu , pgsql-hackers@lists.postgresql.org Subject: Re: REPACK enhancements In-reply-to: References: <28303.1790158015@localhost> <179017302006.2626644.6788432141295311288@gmail.com> <18680.1790247323@localhost> Comments: In-reply-to shihao zhong message dated "Thu, 24 Sep 2026 09:32:08 -0400." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <103629.1790258554.1@localhost> Content-Transfer-Encoding: quoted-printable Date: Thu, 24 Sep 2026 16:02:34 +0200 Message-ID: <103630.1790258554@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk shihao zhong wrote: > One more for 0008, for your next version. > = > finalize_block_range() moves *range_start_dst_p before the replay. If th= e replay adds pages to the new heap, the next update_identity_index > () indexes those rows again. REPACK then fails with a duplicate key erro= r. Right, I've noticed that earlier this week when addressing your other findings. The fix will be included in the next version. Thanks. -- = Antonin Houska Web: https://www.cybertec-postgresql.com