From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove win32ver.rc from version_stamp.pl
In-reply-to: <5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com>
References: <1ee46ac4-a9b2-4531-bf54-5ec2e374634d@2ndquadrant.com>
 <10989.1583103086@sss.pgh.pa.us>
 <5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 09 Mar 2020 08:43:25 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10431.1583765753.1@sss.pgh.pa.us>
Date: Mon, 09 Mar 2020 10:55:53 -0400
Message-ID: <10432.1583765753@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-03-01 23:51, Tom Lane wrote:
>> In general, while I'm on board with the idea, I wonder whether it
>> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string,
>> and just add PG_MAJORVERSION_NUM alongside of it.

> Agreed.  Here is another patch.

This version LGTM.  (I can't actually test the Windows aspects
of this, but I assume you did.)

I'm wondering a little bit whether it'd be worth back-patching the
additions of the new #defines.  That would cut about five years off
the time till they could be relied on by extensions.  However,
I'm not sure anyone is eager to rely on them, so it may not be
worth the effort.

			regards, tom lane