Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ka4EP-0000fM-9k for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Nov 2020 21:52:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ka4EO-0001l4-8i for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Nov 2020 21:52:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ka4EO-0001kx-29 for pgsql-hackers@lists.postgresql.org; Tue, 03 Nov 2020 21:52:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ka4EM-00030j-1y for pgsql-hackers@postgresql.org; Tue, 03 Nov 2020 21:52:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 0A3LqTiR1046811; Tue, 3 Nov 2020 16:52:29 -0500 From: Tom Lane To: Thomas Munro cc: David Rowley , Julien Rouhaud , Peter Eisentraut , Michael Paquier , Robert Haas , Laurenz Albe , Douglas Doole , Christoph Berg , Pg Hackers , =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= Subject: Re: Collation versioning In-reply-to: References: <20200813095204.f7mlgdzsbaxa3mzr@nol> <20200814073746.GF2057@paquier.xyz> <20200814090235.ifld2qvaw43pzpzg@nol> <20200907031741.GK2455@paquier.xyz> <20200908144507.GA57691@nol> <20200924094854.abjmpfqixq6xd4o5@nol> <686359.1604339499@sss.pgh.pa.us> Comments: In-reply-to Thomas Munro message dated "Wed, 04 Nov 2020 10:48:24 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1046809.1604440349.1@sss.pgh.pa.us> Date: Tue, 03 Nov 2020 16:52:29 -0500 Message-ID: <1046810.1604440349@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thomas Munro writes: > On Tue, Nov 3, 2020 at 4:38 PM Thomas Munro wrote: >> On Tue, Nov 3, 2020 at 1:51 PM David Rowley wrote: >>> FWIW, the attached does fix the issue for me. It basically just calls >>> the function that converts the windows-type "English_New Zealand.1252" >>> locale name string into, e.g. "en_NZ". > We want the same algorithm that Windows uses internally to resolve the > old style name to a collation; in other words we probably want > something more like the code path that they took away in VS2015 :-(. Yeah. In the short run, though, it'd be nice to un-break the buildfarm. Maybe we could push David's code or something similar, and then contemplate better ways at leisure? regards, tom lane