Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mP7ax-0007FD-Sv for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Sep 2021 18:19:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mP7av-000326-KW for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Sep 2021 18:19:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mP7av-00031y-Cx for pgsql-hackers@lists.postgresql.org; Sat, 11 Sep 2021 18:19:17 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mP7as-0004VH-VV for pgsql-hackers@lists.postgresql.org; Sat, 11 Sep 2021 18:19:16 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 18BIJ4gl105346; Sat, 11 Sep 2021 14:19:04 -0400 From: Tom Lane To: Jacob Champion cc: "pryzby@telsasoft.com" , "peter.eisentraut@enterprisedb.com" , "pgsql-hackers@lists.postgresql.org" , "buschmann@nidsa.net" , "andrew@dunslane.net" , "noah@leadboat.com" , "tomas.vondra@2ndquadrant.com" , "bruce@momjian.us" , "andres@anarazel.de" Subject: Re: pg_upgrade test for binary compatibility of core data types In-reply-to: References: <20201216172222.GS30237@telsasoft.com> <20201227190729.GB26311@telsasoft.com> <20210112041352.GY1849@telsasoft.com> <20210112171559.GO4320@momjian.us> <20210112172753.GC1849@telsasoft.com> <20210112175356.GP4320@momjian.us> <66753439-83ae-7be5-6e41-9537a6041a39@dunslane.net> <1575064.1615060903@sss.pgh.pa.us> <20210430183348.GQ27406@telsasoft.com> Comments: In-reply-to Jacob Champion message dated "Fri, 16 Jul 2021 18:02:18 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <105344.1631384344.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 11 Sep 2021 14:19:04 -0400 Message-ID: <105345.1631384344@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jacob Champion writes: > On Fri, 2021-04-30 at 13:33 -0500, Justin Pryzby wrote: >> I started this. I don't know if it's compatible with the buildfarm cli= ent, but >> I think any issues maybe can be avoided by using "IF EXISTS". > Here are the differences I see on a first pass (without putting too > much thought into how significant the differences are). Buildfarm code > I'm comparing against is at [1]. I switched the CF entry for this to "Waiting on Author". It's been failing in the cfbot for a couple of months, and Jacob's provided some review-ish comments here, so I think there's plenty of reason to deem the ball to be in Justin's court. regards, tom lane