Date: Thu, 25 Aug 2016 09:10:29 +0000 (UTC)
From: amul sul <sul_amul@yahoo.co.in>
Reply-To: amul sul <sul_amul@yahoo.co.in>
To: Artur Zakirov <a.zakirov@postgrespro.ru>,
	Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Alex Ignatov <a.ignatov@postgrespro.ru>,
	Bruce Momjian <bruce@momjian.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Message-ID: <1054231194.17565594.1472116229825.JavaMail.yahoo@mail.yahoo.com>
In-Reply-To: <22dbe4e0-b550-ca86-8634-adcda0faa159@postgrespro.ru>
References: 
 <1873520224.1784572.1465833145330.JavaMail.yahoo.ref@mail.yahoo.com>
 <CAKFQuwb2gp8n2ai_agyJod5BTYxL7ek0AjB9zifDSceK6QntnQ@mail.gmail.com>
 <CA+TgmoaWTgbtd2RTwVvySMVoOcHmWq66rCCxtVywOOX3FJy4tQ@mail.gmail.com>
 <31915.1466703655@sss.pgh.pa.us>
 <CA+TgmoaFQZeqmAo3CdivNu70coB=9eM5OroKYtNcTuMaC1kuUQ@mail.gmail.com>
 <32684.1466704957@sss.pgh.pa.us>
 <734e50cd-c563-4afd-d1c8-80f244b3265e@postgrespro.ru>
 <CAFj8pRDGxe=cdcZ7pur=2WeW9O3MQCZTBEAOJfQ7OLQJaYXDvw@mail.gmail.com>
 <b2a39359-3282-b402-f4a3-057aae500ee7@postgrespro.ru>
 <1285870380.13225431.1471272994354.JavaMail.yahoo@mail.yahoo.com>
 <CA+TgmoZEWyszzwDGFZ2i1psDgHrdPeZE5Hvs570Q1KfkCfqwgw@mail.gmail.com>
 <d7ffcce8-491f-7969-71a6-73272ad31dfd@postgrespro.ru>
 <60cc3122-0950-e455-21fe-de89882e285d@postgrespro.ru>
 <2095510729.14135736.1471444528728.JavaMail.yahoo@mail.yahoo.com>
 <CA+Tgmoa4FVrCikyOVGVF6HqGZ92CrkBodDnm4SCeC-o2OiHWrg@mail.gmail.com>
 <03e76bef-75eb-4d70-40d6-890d42f4dc8e@postgrespro.ru>
 <22dbe4e0-b550-ca86-8634-adcda0faa159@postgrespro.ru>
Subject: Re: Bug in to_timestamp().
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Length: 957
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Thursday, August 25, 2016 1:56 PM, Artur Zakirov <a.zakirov@postgrespro.=
ru> wrote:
>> #2. Warning at compilation;
>>
>> formatting.c: In function =E2=80=98do_to_timestamp=E2=80=99:
>> formatting.c:3049:37: warning: =E2=80=98prev_type=E2=80=99 may be used u=
ninitialized in this function [-Wmaybe-uninitialized]
>> if (prev_type =3D=3D NODE_TYPE_SPACE || prev_type =3D=3D NODE_TYPE_SEPAR=
ATOR)
>> ^
>> formatting.c:2988:5: note: =E2=80=98prev_type=E2=80=99 was declared here
>> prev_type;
>> ^
>>
>> You can avoid this by assigning  zero (or introduce NODE_TYPE_INVAL ) to=
 prev_type at following line:
>>
>> 256 +               prev_type;
>
>
>You are right. I assigned to prev_type NODE_TYPE_SPACE to be able to=20
>execute such query:
>
>
>SELECT to_timestamp('---2000----JUN', 'YYYY MON');
>
>
>Will be it a proper behaviour?


Looks good to me, no one will complain if something working on PG but not o=
n Oracle.=20


Thanks & Regards,
Amul Sul


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers