Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nYzSz-0001ch-3b
	for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Mar 2022 00:12:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nYzSx-0001Q6-Oh
	for pgsql-hackers@arkaria.postgresql.org; Tue, 29 Mar 2022 00:12:07 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nYzSx-0001Px-FP
	for pgsql-hackers@lists.postgresql.org; Tue, 29 Mar 2022 00:12:07 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nYzSu-00079D-SS
	for pgsql-hackers@postgresql.org; Tue, 29 Mar 2022 00:12:06 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22T0Bs0F1054321;
	Mon, 28 Mar 2022 20:11:54 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Robert Haas <robertmhaas@gmail.com>,
        Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= <ilmari@ilmari.org>,
        Dipesh Pandit <dipesh.pandit@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Jeevan Ladhe <jeevanladhe.os@gmail.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        "Shinoda,
    Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
        Abhijit Menon-Sen <ams@toroid.org>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>,
        Mark Dilger <mark.dilger@enterprisedb.com>,
        pgsql-hackers@postgresql.org, tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c (zstd workers)
In-reply-to: <20220329000727.GV28503@telsasoft.com>
References: <20220321131833.GB28503@telsasoft.com>
 <CA+TgmoZz-F1pA1Vv=-6FOPWuS1eFi2ifNyySV4u6pW0+FBeG-g@mail.gmail.com>
 <20220321182256.GC28503@telsasoft.com>
 <CA+TgmoYJ=9Y=+fJ9WyAXAExTmpArCZEdRu1iVQ_2je+heTZGrg@mail.gmail.com>
 <871qyvrvvm.fsf@wibble.ilmari.org>
 <CA+Tgmobummc+reyzZJwnua7KXPC9sromDqYx1uoZ49mxq=LRfQ@mail.gmail.com>
 <384291.1648403267@sss.pgh.pa.us>
 <CA+TgmoZ1DbW_nKeVteVvYt0WvZDhm77_qdb-TErjctW+h5_3Jg@mail.gmail.com>
 <20220328205329.GT28503@telsasoft.com>
 <CA+TgmoYw=UFomz2f8Uq0LtUmvcReRFqKb19YwO2O0Wv0Azz_ng@mail.gmail.com>
 <20220329000727.GV28503@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Mon, 28 Mar 2022 19:07:27 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1054319.1648512714.1@sss.pgh.pa.us>
Date: Mon, 28 Mar 2022 20:11:54 -0400
Message-ID: <1054320.1648512714@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1054320.1648512714%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> Also, why wouldn't *kwend be checked in any case ?

I suspect Robert wrote it that way intentionally --- but if so,
I agree it could do with more than zero commentary.

			regards, tom lane