Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Cleanup shadows variable warnings, round 1
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHut+PsP+5ov_=zhsd+yGunCCfTSM0qXe-a0VHwGyzQOe-SYxQ@mail.gmail.com>
Date: Thu, 4 Dec 2025 07:04:02 +0800
Cc: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 Peter Eisentraut <peter@eisentraut.org>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <105E05F5-4BF1-459F-8012-94D90C75BE0F@gmail.com>
References: <94ECEF6E-681B-40DF-8F6B-4CABE4CDB96A@gmail.com>
 <202512031432.cpvnk5irwygr@alvherre.pgsql>
 <CAHut+PsP+5ov_=zhsd+yGunCCfTSM0qXe-a0VHwGyzQOe-SYxQ@mail.gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/105E05F5-4BF1-459F-8012-94D90C75BE0F%40gmail.com>
Precedence: bulk


> On Dec 4, 2025, at 05:00, Peter Smith <smithpb2250@gmail.com> wrote:
>=20
> On Thu, Dec 4, 2025 at 1:36=E2=80=AFAM =C3=81lvaro Herrera =
<alvherre@kurilemu.de> wrote:
>>=20
>> On 2025-Dec-03, Chao Li wrote:
>>=20
>>> Unfortunately that doesn=E2=80=99t work for my compiler (clang on =
MacOS),
>>> that=E2=80=99s why I renamed =E2=80=9CI" to =E2=80=9Cu=E2=80=9D.
>>=20
>> I think you're missing his point.  He's suggesting to change not only
>> this variable, but also the other uses of "i" in this function.
>>=20
>=20
> Exactly. I should have posted the larger diff, as you did. Thanks for
> clarifying.
>=20

Sorry for misunderstanding you. I guess I read your message too quickly =
yesterday. Will fix it in v4.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/