From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org, Noah Misch <noah@leadboat.com>
Subject: Re: Fixing AC_CHECK_DECLS to do the right thing with clang
In-reply-to: <20181118212037.xk542sjuxlxk7bkx@alap3.anarazel.de>
References: <26819.1542515567@sss.pgh.pa.us>
 <20181118212037.xk542sjuxlxk7bkx@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sun, 18 Nov 2018 13:20:37 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10667.1542578568.1@sss.pgh.pa.us>
Date: Sun, 18 Nov 2018 17:02:48 -0500
Message-ID: <10668.1542578568@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Seems like a good plan. The problem doesn't reproduce for me on debian
> (using any version of clang), so all I can report is that at patched
> build still works as it should.

Interesting.  It's hardly surprising that the problem would occur only
on some platforms, since if <string.h> declares the function then the
problem isn't visible.  But I'm surprised that some Debian boxes would
show it and some not.  Still, a closer look at the buildfarm shows both
clang-on-Debian members with the warning (eg gull) and clang-on-Debian
members without (eg yours).

			regards, tom lane