From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: David Steele <david@pgmasters.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: C99 compliance for src/port/snprintf.c
In-reply-to: <20180815222401.kxsupl5zie2jgi4x@alap3.anarazel.de>
References: <9456.1534347706@sss.pgh.pa.us>
 <20180815155237.pz5fgfmdo4cgqjta@alap3.anarazel.de>
 <CA+TgmoYvHzFkwChsamwbBrLNJRcRq+fyTwveFaN_YOWUsRnfpw@mail.gmail.com>
 <11138.1534349838@sss.pgh.pa.us>
 <dd48e765-9afe-4695-b2f4-f3cc0c1218e0@2ndQuadrant.com>
 <20825.1534360737@sss.pgh.pa.us>
 <e452e970-cf80-6e7e-17c1-24730a5c9ca9@pgmasters.net>
 <2069.1534363063@sss.pgh.pa.us>
 <20180815214931.vlwsz4s55enbppna@alap3.anarazel.de>
 <9877.1534371239@sss.pgh.pa.us>
 <20180815222401.kxsupl5zie2jgi4x@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 15 Aug 2018 15:24:01 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <10674.1534372270.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 15 Aug 2018 18:31:10 -0400
Message-ID: <10675.1534372270@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-08-15 18:13:59 -0400, Tom Lane wrote:
>> Experimenting here says that even reasonably modern gcc's won't take
>> declarations-inside-for without "--std=c99" or such.

> I think autoconf's magic knows about most of that:
>  — Macro: AC_PROG_CC_C99

Ah, of course.  What about the MSVC build?

> I think we could get a start by adding that test to configure, without
> relying on it for now (i.e. keeping mylodon with -Wc99-extensions
> -Werror=c99-extensions alive). That'd tell us about which machines,
> besides presumably gaur, we'd need to either kick to the curb or change.

Sure, no objection to putting that in just to see how much of the
buildfarm can handle it.  If the answer turns out to be "a lot",
we might have to reconsider, but gathering data seems like the
first thing to do.

			regards, tom lane