Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1k7fgB-0007IN-MW
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Aug 2020 14:00:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1k7fgA-0002ZX-Jm
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Aug 2020 14:00:02 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1k7fgA-0002ZO-D4
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Aug 2020 14:00:02 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1k7fg3-00073p-Kx
	for pgsql-hackers@postgresql.org; Mon, 17 Aug 2020 14:00:02 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 07HDxdfB1069284;
	Mon, 17 Aug 2020 09:59:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Newline after --progress report
In-reply-to: <e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi>
References: <82b539e5-ae33-34b0-1aee-22b3379fd3eb@iki.fi>
 <572250.1597413104@sss.pgh.pa.us>
 <e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Mon, 17 Aug 2020 10:14:38 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1069282.1597672779.1@sss.pgh.pa.us>
Date: Mon, 17 Aug 2020 09:59:39 -0400
Message-ID: <1069283.1597672779@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Good point. Pushed a patch along those lines.

Uh ... you patched v12 but not v13?

Also, I'd recommend that you NOT do this:

+   fprintf(stderr, (!finished && isatty(fileno(stderr))) ? "\r" : "\n");

as it breaks printf format verification in many/most compilers.

			regards, tom lane