Feedback-ID: ie0a040ee:Fastmail
Message-ID: <106cbedd-8a64-4e22-91a5-a2033abc3bed@eisentraut.org>
Date: Mon, 22 Jan 2024 19:35:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: make dist using git archive
Content-Language: en-US
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <40e80f77-a294-4f29-a16f-e21bc7bc75fc@eisentraut.org>
 <CAEG8a3+wTDJWz+ECNU=A_=51usyGrHyKO52jmG7QPF632tZSbg@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAEG8a3+wTDJWz+ECNU=A_=51usyGrHyKO52jmG7QPF632tZSbg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/106cbedd-8a64-4e22-91a5-a2033abc3bed%40eisentraut.org>
Precedence: bulk

On 22.01.24 13:10, Junwang Zhao wrote:
> I played this with meson build on macOS, the packages are generated
> in source root but not build root, I'm sure if this is by design but I think
> polluting *working directory* is not good.

Yes, it's not good, but I couldn't find a way to make it work.

This is part of the complications with meson I referred to.  The 
@BUILD_ROOT@ placeholder in custom_target() is apparently always a 
relative path, but it doesn't know that git -C changes the current 
directory.

> Another thing I'd like to point out is, should we also introduce *git commit*
> or maybe *git tag* to package name, something like:
> 
> git archive --format tar.gz --prefix postgresql-17devel/ HEAD -o
> postgresql-17devel-`git rev-parse --short HEAD`.tar.gz
> git archive --format tar.gz --prefix postgresql-17devel/ HEAD -o
> postgresql-`git describe --tags`.tar.gz

I'm not sure why we would need it built-in.  It can be done by hand, of 
course.