Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwXhe-002Uo1-9w for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Apr 2024 01:33:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rwXhc-00HRfx-K3 for pgsql-hackers@arkaria.postgresql.org; Tue, 16 Apr 2024 01:33:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwXhc-00HRfp-AL for pgsql-hackers@lists.postgresql.org; Tue, 16 Apr 2024 01:33:40 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwXhZ-0033c2-BB for pgsql-hackers@lists.postgresql.org; Tue, 16 Apr 2024 01:33:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 43G1XYYf1071981; Mon, 15 Apr 2024 21:33:34 -0400 From: Tom Lane To: Andres Freund cc: pgsql-hackers@lists.postgresql.org Subject: Re: Bugs in ecpg's macro mechanism In-reply-to: <20240416010544.tsupdybl752vywkw@awork3.anarazel.de> References: <998011.1713217712@sss.pgh.pa.us> <20240415231044.fjjibtnwcypowzni@awork3.anarazel.de> <1063578.1713228436@sss.pgh.pa.us> <20240416010544.tsupdybl752vywkw@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 15 Apr 2024 18:05:44 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1071979.1713231214.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 15 Apr 2024 21:33:34 -0400 Message-ID: <1071980.1713231214@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2024-04-15 20:47:16 -0400, Tom Lane wrote: >> Ah, thanks. I guess this depends on getopt_long reordering arguments >> (since the "-o outfile" bit will come later). That is safe enough >> in HEAD since 411b72034, but it might fail on weird platforms in v16. >> How much do we care about that? (We can avoid that hazard in the >> makefile build easily enough.) > As moving the arguments around would just be the following, I see no rea= son to > just do so. Fair enough. I'm inclined to include that change only in v16, though. regards, tom lane