Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1itZDO-0002g0-5t
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2020 15:43:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1itZDL-0001GT-SF
	for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Jan 2020 15:43:43 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1itZDL-0001GM-Fd
	for pgsql-hackers@lists.postgresql.org; Mon, 20 Jan 2020 15:43:43 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1itZDE-0001fh-S6
	for pgsql-hackers@postgresql.org; Mon, 20 Jan 2020 15:43:42 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 00KFhW07010755;
	Mon, 20 Jan 2020 10:43:32 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: John Naylor <john.naylor@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add support for automatically updating Unicode derived files
In-reply-to: <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com>
References: <c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com>
 <CACPNZCv2jmjpqkatr-NBJ8wpP6trY8MPBbW8nhqi--hL-0+dgQ@mail.gmail.com>
 <ff2f8e99-ac2b-1940-81c5-8b2fd1e674e7@2ndquadrant.com>
 <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
 <acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com>
 <26652.1579048650@sss.pgh.pa.us>
 <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Mon, 20 Jan 2020 09:59:34 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10753.1579535012.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 20 Jan 2020 10:43:32 -0500
Message-ID: <10754.1579535012@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-01-15 01:37, Tom Lane wrote:
>> This patch is making src/tools/pginclude/headerscheck unhappy:
>> ./src/include/common/unicode_combining_table.h:3: error: array type has=
 incomplete element type

> Hmm, this file is only meant to be included inside one particular =

> function.  Making it standalone includable would seem to be unnecessary.=
 =

>   What should we do?

Well, we could make it a documented exception in headerscheck and
cpluspluscheck.

			regards, tom lane