Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lu4Cy-0003QC-SO
	for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 02:26:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lu4Cx-0000Z9-DP
	for pgsql-hackers@arkaria.postgresql.org; Fri, 18 Jun 2021 02:26:11 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lu4Cx-0000Z1-5k
	for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 02:26:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lu4Cr-0000yS-0D
	for pgsql-hackers@lists.postgresql.org; Fri, 18 Jun 2021 02:26:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 15I2Q04G1077204;
	Thu, 17 Jun 2021 22:26:00 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org
Subject: Re: Centralizing protective copying of utility statements
In-reply-to: <YMvvZp96z7xffnok@paquier.xyz>
References: <931771.1623893989@sss.pgh.pa.us>
 <974666.1623943810@sss.pgh.pa.us> <1026052.1623949409@sss.pgh.pa.us>
 <20210617192543.fgiffbsiyxdf47iz@alap3.anarazel.de>
 <1040162.1623959602@sss.pgh.pa.us>
 <20210617201722.c54pjyf3mxlvamqq@alap3.anarazel.de>
 <1058642.1623963057@sss.pgh.pa.us>
 <20210617210834.2pwayaburyxkr35j@alap3.anarazel.de>
 <YMvvZp96z7xffnok@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 18 Jun 2021 09:57:10 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1077202.1623983160.1@sss.pgh.pa.us>
Date: Thu, 17 Jun 2021 22:26:00 -0400
Message-ID: <1077203.1623983160@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1077203.1623983160%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> The DECLARE CURSOR case in ExplainOneUtility() does a copy of a Query.
> Perhaps a comment should be added to explain why a copy is still
> required?

I did add a comment about that in the v2 patch --- the issue is the
call path for EXPLAIN EXECUTE.

			regards, tom lane