Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAuJY-0004gN-Rh for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jul 2022 14:23:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuJX-0001xj-Jf for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jul 2022 14:23:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAuJX-0001x0-Ag for pgsql-hackers@lists.postgresql.org; Mon, 11 Jul 2022 14:23:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAuJV-0006dr-4M for pgsql-hackers@postgresql.org; Mon, 11 Jul 2022 14:23:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26BEMx2G1079553; Mon, 11 Jul 2022 10:22:59 -0400 From: Tom Lane To: Peter Eisentraut cc: Andres Freund , David Rowley , pgsql-hackers Subject: Re: automatically generating node support functions In-reply-to: <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com> References: <1294462.1656875649@sss.pgh.pa.us> <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com> <1593978.1656953960@sss.pgh.pa.us> <2592455.1657140387@sss.pgh.pa.us> <3302658.1657288366@sss.pgh.pa.us> <611d2e! 93-6330-47fa-0970-72316aed50f2@enterprisedb.com> <3488143.1657310625@sss.pgh.pa.us> <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com> <20220710214622.haiektrjzisob6rl@awork3.anarazel.de> <815831.1657494597@sss.pgh.pa.us> <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Mon, 11 Jul 2022 16:09:24 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1079551.1657549379.1@sss.pgh.pa.us> Date: Mon, 11 Jul 2022 10:22:59 -0400 Message-ID: <1079552.1657549379@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 11.07.22 01:09, Tom Lane wrote: >> The rest could probably be alphabetical. I was also wondering if >> all of them really need to be read at all --- I'm unclear on what >> access/sdir.h is contributing, for example. > could not handle type "ScanDirection" in struct "IndexScan" field > "indexorderdir" Ah, I see. Still, we could also handle that with push @enum_types, qw(ScanDirection); which would be exactly one place that needs to know about this, rather than the three (soon to be four) places that know that access/sdir.h needs to be read and then mostly ignored. regards, tom lane