Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTyFL-0002Pv-66 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Jan 2017 21:58:23 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cTyFK-0004c3-KY for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Jan 2017 21:58:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cTyDt-0001y7-Rb for pgsql-hackers@postgresql.org; Wed, 18 Jan 2017 21:56:53 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cTyDq-0001om-Oi for pgsql-hackers@postgresql.org; Wed, 18 Jan 2017 21:56:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v0ILukGp001081; Wed, 18 Jan 2017 16:56:46 -0500 From: Tom Lane To: Andres Freund cc: Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) In-reply-to: <20170118214702.54b2mdbxce5piwv5@alap3.anarazel.de> References: <32021.1484678618@sss.pgh.pa.us> <20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de> <837.1484680521@sss.pgh.pa.us> <12780.1484747004@sss.pgh.pa.us> <20170118191924.25lfp6rd6y3kw5sa@alap3.anarazel.de> <13690.1484767452@sss.pgh.pa.us> <20170118193420.znochutmnzusd636@alap3.anarazel.de> <15814.1484769612@sss.pgh.pa.us> <460325A6-EF35-4A29-A1A0-EEDC3EDCF750@anarazel.de> <22709.1484771072@sss.pgh.pa.us> <20170118214702.54b2mdbxce5piwv5@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 18 Jan 2017 13:47:02 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1079.1484776606.1@sss.pgh.pa.us> Date: Wed, 18 Jan 2017 16:56:46 -0500 Message-ID: <1080.1484776606@sss.pgh.pa.us> X-Pg-Spam-Score: -5.1 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andres Freund writes: > There's one sgml comment you'd added: > "Furthermore, nested set-returning functions did not work at all." > I'm not quite sure what you're referring to there - it was previously > allowed to have one set argument to an SRF: Ooops ... that was composed too hastily, evidently. Will fix. I'll try to write something about the SRF-in-CASE issue too. Seeing whether we can document that adequately seems like an important part of making the decision about whether we need to block it. > Working on rebasing the cleanup patch now. Interested in reviewing > that? Otherwise I think I'll just push the rebased version of what I'd > posted before, after making another pass through it. I have not actually looked at 0003 at all yet. So yeah, please post for review after you're done rebasing. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers