Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1twmTa-0002Pk-Au for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Mar 2025 18:24:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1twmTY-0085li-O5 for pgsql-hackers@arkaria.postgresql.org; Mon, 24 Mar 2025 18:24:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1twmTY-0085la-EQ for pgsql-hackers@lists.postgresql.org; Mon, 24 Mar 2025 18:24:40 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1twmTW-000uGJ-2H for pgsql-hackers@postgresql.org; Mon, 24 Mar 2025 18:24:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 52OIOYCs1085308; Mon, 24 Mar 2025 14:24:34 -0400 From: Tom Lane To: "Euler Taveira" cc: "Robert Haas" , "Andrei Lepikhov" , "Michael Paquier" , "Alexander Korotkov" , "Yurii Rashkovskii" , pgsql-hackers Subject: Re: Add Postgres module info In-reply-to: References: <506788.1733941263@sss.pgh.pa.us> <2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com> <556341.1733967371@sss.pgh.pa.us> <0844622e-9967-409a-8038-470a36f1039c@gmail.com> <8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com> <982748.1734059835@sss.pgh.pa.us> <0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com> <29d29c3e-ac9e-48cc-87b4-b1cfd8c2ede8@gmail.com> <992ec366-5c0d-4f23-a02e-30e663613f44@gmail.com> <4476e8cd-6427-4470-98a8-8d61b82d8b1e@gmail.com> <441661.1742683797@sss.pgh.pa.us> <796058.1742757002@sss.pgh.pa.us> <1003653.1742831657@sss.pgh.pa.us> Comments: In-reply-to "Euler Taveira" message dated "Mon, 24 Mar 2025 15:14:23 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1085306.1742840674.1@sss.pgh.pa.us> Date: Mon, 24 Mar 2025 14:24:34 -0400 Message-ID: <1085307.1742840674@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk "Euler Taveira" writes: > I think those modules without control file, it is natural to use PG_VERSION. > However, I'm concerned that users can confuse the version if we provide > PG_VERSION as version and the extension catalog says something different. Maybe, but the values will be sufficiently different that I don't think the confusion will last long. Anyway I don't want the version in an extension's module to mean something totally different than the version in a non-extension module. I could possibly get behind setting version = PG_VERSION and having another field "ext_version" or such that shows the expected current extension version if the module belongs to an extension. I'm not really convinced it's worth the trouble, though. regards, tom lane