From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Alexander Korotkov <a.korotkov@postgrespro.ru>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Hash join explain is broken
In-reply-to: <29496.1562026087@sss.pgh.pa.us>
References: 
 <CAPpHfdvGVegF_TKKRiBrSmatJL2dR9uwFCuR+teQ_8tEXU8mxg@mail.gmail.com>
 <20190611074557.bf6wejaj6ctrjxqd@alap3.anarazel.de>
 <20190611082220.eyhgjj47bj6jdkqp@alap3.anarazel.de>
 <23550.1560465527@sss.pgh.pa.us>
 <93FA6FE5-03C5-4AB1-B0D8-C1FA00C72121@anarazel.de>
 <20190618070027.a3sh7z7afgsdyzyy@alap3.anarazel.de>
 <20190702000150.uv6hzllogkv3gu37@alap3.anarazel.de>
 <29496.1562026087@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 01 Jul 2019 20:08:07 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10855.1562079002.1@sss.pgh.pa.us>
Date: Tue, 02 Jul 2019 10:50:02 -0400
Message-ID: <10856.1562079002@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> Tom, any comments? Otherwise I'll go ahead, and commit after a round or
>> two of polishing.

> Sorry for not getting to this sooner --- I'll try to look tomorrow.

I took a look, and I think this is going in the right direction.
We definitely need a test case corresponding to the live bug,
and I think the comments could use more work, and there are some
cosmetic things (I wouldn't add the new struct Hash field at the
end, for instance).

			regards, tom lane