From: Antonin Houska <ah@cybertec.at>
To: Chao Li <li.evan.chao@gmail.com>
cc: Alvaro Herrera <alvherre@kurilemu.de>,
    Matthias van de Meent <boekewurm+postgres@gmail.com>,
    Nathan Bossart <nathandbossart@gmail.com>,
    pgsql-hackers@postgresql.org
Subject: Re: REPACK (CONCURRENTLY) fails when replica identity index is
 dropped
In-reply-to: <D1A9CED4-4141-4EBA-A332-F4E683EA46ED@gmail.com>
References: <aqKC6K_QO0OEv3gy@alvherre.pgsql> <45513.1789063796@localhost>
 <D1A9CED4-4141-4EBA-A332-F4E683EA46ED@gmail.com>
Comments: In-reply-to Chao Li <li.evan.chao@gmail.com>
   message dated "Fri, 11 Sep 2026 09:42:15 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Fri, 11 Sep 2026 10:06:26 +0200
Message-ID: <10924.1789113986@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/10924.1789113986%40localhost>
Precedence: bulk

Chao Li <li.evan.chao@gmail.com> wrote:

> On Sep 11, 2026, at 02:09, Antonin Houska <ah@cybertec.at> wrote:

> > Alvaro Herrera <alvherre@kurilemu.de> wrote:
> >
> > > Actually, wouldn't it make more sense to reset the replica identity b=
ack
> > > to 'd' when the index is dropped, as in the attached patch?
> >
> > Even though users probably do not drop the identity index too often, I =
think
> > it's possible that someone tries to drop an index that seems to be
> > unnecessary, but forgets that it's in use by logical replication. In su=
ch
> > case, I tend to consider ERROR better response than broken replication.

> +1
>
> Actually, there was a similar discussion in [1]. In that case, the questi=
on was whether setting a table to UNLOGGED should fail when the table is in=
 a publication=E2=80=99s EXCEPT list, or whether PG should silently remove =
the table from the EXCEPT list and issue a notice to the user. Most people =
in that discussion, including Amit, seemed to prefer failing the operation.=
 From a user-experience and design-consistency perspective, I think these t=
wo cases are quite similar.
>=20
> [1] https://postgr.es/m/CAA4eK1KHA-mkvtRPKsE-er8ePOnEu59_hxApaQKtr2=3D2GN=
OEQA@mail.gmail.com

I said "broken replication", but actually the missing replica identity index
triggers error even on the *primary*:

postgres=3D# delete from a where i=3D1;
ERROR:  cannot delete from table "a" because it does not have a replica ide=
ntity and publishes deletes
HINT:  To enable deleting from the table, set REPLICA IDENTITY using ALTER
TABLE.

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com