From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Bruce Momjian <bruce@momjian.us>, Jelte Fennema <postgres@jeltef.nl>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>,
        Jesse Zhang <sbjesse@gmail.com>, Andres Freund <andres@anarazel.de>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <CAH2-Wzn_L_kLCw_OLhpBztKwn_aaM0QLmMmubGK4KSxQyJPkbA@mail.gmail.com>
References: <CABUevExkB=+FX5Ht2sU6Tmk1fF0h8LqugW5camQ-r00ftPZoSg@mail.gmail.com> <20200814202651.GA31108@alvherre.pgsql> <CABUevEwGPPaUtObrDywO+vhpFDTJXO+-aeWJd7D46uXTE2sQpA@mail.gmail.com> <CAGECzQQs+hz4uQSmD_8oRLr74GtxpE0iXuYE85+RHAzvkF_yvQ@mail.gmail.com> <Y8whOD51K2ZlcaFz@momjian.us> <CAH2-Wzn_L_kLCw_OLhpBztKwn_aaM0QLmMmubGK4KSxQyJPkbA@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sat, 21 Jan 2023 12:21:03 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1097304.1674334785.1@sss.pgh.pa.us>
Date: Sat, 21 Jan 2023 15:59:45 -0500
Message-ID: <1097305.1674334785@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1097305.1674334785%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> In practice this approach tends to run into problems when the relevant
> AST isn't available. For example, if there's code that only builds on
> Windows, maybe it won't work at all (at least on my Linux system).

Hmm, that could be a deal-breaker.  It's not going to be acceptable
to have to pgindent different parts of the system on different platforms
... at least not unless we can segregate them on the file level, and
even that would have a large PITA factor.

Still, we won't know unless someone makes a serious experiment with it.

			regards, tom lane