From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
In-reply-to: <alpine.DEB.2.21.1901222007100.16643@lancre>
References: <9427.1547701450@sss.pgh.pa.us>
 <alpine.DEB.2.21.1901170659210.7416@lancre> <21538.1547770868@sss.pgh.pa.us>
 <4615.1547792324@sss.pgh.pa.us> <alpine.DEB.2.21.1901180926580.26418@lancre>
 <29225.1547834182@sss.pgh.pa.us> <alpine.DEB.2.21.1901182257480.20734@lancre>
 <alpine.DEB.2.21.1901201051270.14950@lancre> <7879.1548015981@sss.pgh.pa.us>
 <alpine.DEB.2.21.1901202225310.28945@lancre> <9718.1548175497@sss.pgh.pa.us>
 <alpine.DEB.2.21.1901222007100.16643@lancre>
Comments: In-reply-to Fabien COELHO <coelho@cri.ensmp.fr>
	message dated "Tue, 22 Jan 2019 21:35:27 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11056.1548347725.1@sss.pgh.pa.us>
Date: Thu, 24 Jan 2019 11:35:25 -0500
Message-ID: <11057.1548347725@sss.pgh.pa.us>
Precedence: bulk

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> I had in mind something more like the attached.

> Yep.
> I'm not too happy that it mixes API levels, and about the int/double/int 
> path.
> Attached an updated version which relies on pg_jrand48 instead.

Hm, I'm not sure that's really an improvement, but I pushed it like that
(and the other change along with it).

> Also, as 
> the pseudo-random state is fully controlled, seeded test results are 
> deterministic so the expected value can be fully checked.

I found that the "expected value" was different in v11 than HEAD,
which surprised me.  It looks like the reason is that HEAD sets up
more/different RandomStates from the same seed than v11 did.  Not
sure if it's a good thing for this behavior to change across versions.

			regards, tom lane