From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Cramer <davecramer@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>, Tatsuo Ishii <ishii@sraoss.co.jp>,
        nathandbossart@gmail.com, robertmhaas@gmail.com,
        alvherre@alvh.no-ip.org, smithpb2250@gmail.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
In-reply-to: <CADK3HHJ2U_B0Rfdaj=0CMuTO1P-0NEmoAeYqU0XnkiHnqtg1dw@mail.gmail.com>
References: <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com> <859245.1691438528@sss.pgh.pa.us> <20230807214714.GA1284531@nathanxps13> <20230808.074954.718352835768755597.t-ishii@sranhm.sra.co.jp> <CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com> <b9b949be-dff6-e75f-c95b-71afc70cfa5d@eisentraut.org> <CADK3HHJ2U_B0Rfdaj=0CMuTO1P-0NEmoAeYqU0XnkiHnqtg1dw@mail.gmail.com>
Comments: In-reply-to Dave Cramer <davecramer@gmail.com>
	message dated "Wed, 09 Aug 2023 10:27:37 -0600"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <110572.1691598848.1@sss.pgh.pa.us>
Date: Wed, 09 Aug 2023 12:34:08 -0400
Message-ID: <110573.1691598848@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/110573.1691598848%40sss.pgh.pa.us>
Precedence: bulk

Dave Cramer <davecramer@gmail.com> writes:
> On Wed, 9 Aug 2023 at 09:19, Peter Eisentraut <peter@eisentraut.org> wrote:
>> 3. IMO, the names of the protocol messages in protocol.sgml are
>> canonical.  Your patch appends "Request" and "Response" in cases where
>> that is not part of the actual name.  Also, some messages are documented
>> to go both ways, so this separation doesn't make sense strictly
>> speaking.  Please use the names as in protocol.sgml without augmenting
>> them.

> I've changed this a number of times. I do not mind changing it again, but
> can we reach a consensus ?

I agree with Peter: let's use the names in the protocol document
with a single prefix.  I've got mixed feelings about whether that prefix
should have an underscore, though.

			regards, tom lane