Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vxUn7-00Gbin-13
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Mar 2026 18:48:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1vxUn4-008I0W-1f
	for pgsql-hackers@arkaria.postgresql.org;
	Tue, 03 Mar 2026 18:48:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vxUn4-008I0M-0l
	for pgsql-hackers@lists.postgresql.org;
	Tue, 03 Mar 2026 18:48:18 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vxUn2-00000000IY4-0plI
	for pgsql-hackers@lists.postgresql.org;
	Tue, 03 Mar 2026 18:48:18 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 623IlvEx1108078;
	Tue, 3 Mar 2026 13:47:57 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Yura Sokolov <y.sokolov@postgrespro.ru>,
 Sami Imseih <samimseih@gmail.com>,
        Chao Li <li.evan.chao@gmail.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fix bug in multixact Oldest*MXactId initialization and access
In-reply-to: <824fe90a-9954-4964-a177-bc8789f06d13@iki.fi>
References: <7acc94b0-ea82-4657-b1b0-77842cb7a60c@postgrespro.ru>
 <bf2951b4-687b-4bd3-a072-46deb463f177@postgrespro.ru>
 <CAA5RZ0t8iGnqO3JcAZP1VEjCspcnZtQ0GFFVGLNLAsFqfHqRsw@mail.gmail.com>
 <ebeb0db1-0eb2-4439-a6c8-1d96b60b25ad@postgrespro.ru>
 <CAA5RZ0s+rr=DVkFnMwupgnCAvPjJkjQ3jr5=7X_=Sb5Mr02-Mg@mail.gmail.com>
 <3d7a2207-0e61-4d95-bc00-e5248956a32b@postgrespro.ru>
 <366b6f95-613d-4ef8-82e4-bb2fd06d9c4d@iki.fi>
 <CAA5RZ0vXCMHEsPg7wFXmBOEPgWB8NvGKWx9cZsz7F99mFU+xLw@mail.gmail.com>
 <231cd950-73e9-4db5-a516-c5216af7b93a@iki.fi>
 <944d7897-3ec3-47bb-9e93-b99f2ef3124a@postgrespro.ru>
 <CAA5RZ0umyHiQNwr1m6FVF0WPCP3QAFAzdF=mQ+_u-vknhOBYWw@mail.gmail.com>
 <A0249625-0EF4-4068-854F-0592139DFBC1@gmail.com>
 <c585168a-210a-4728-8e5e-8e9384126ccd@iki.fi>
 <CAA5RZ0s3wL+4RJRRtJVK1VxEgAmYrj7ftfSuAJHJ+oDfTabQbg@mail.gmail.com>
 <120550bf-ca50-4a07-91b1-a88f1434ee8b@postgrespro.ru> <e7c8a4ef-458a-4e7!
 2-be09-51c65ab446d5@iki.fi> <1009073.1772551323@sss.pgh.pa.us>
 <824fe90a-9954-4964-a177-bc8789f06d13@!
 iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Tue, 03 Mar 2026 18:59:34 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1108076.1772563676.1@sss.pgh.pa.us>
Date: Tue, 03 Mar 2026 13:47:57 -0500
Message-ID: <1108077.1772563677@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1108077.1772563677%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 03/03/2026 17:22, Tom Lane wrote:
>> I wonder if we couldn't reduce future maintenance effort for
>> prepared_xacts_1.out by modifying that test script to make an
>> early exit if prepared transactions are disabled.

> +1, I was just thinking the same.

Personally I'd put the exit test after the file's header comment,
but that's just a quibble.  LGTM otherwise.

			regards, tom lane