From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, David Steele <david@pgmasters.net>,
        Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
        Stephen Frost <sfrost@snowman.net>,
        Amit Kapila <amit.kapila16@gmail.com>,
        Suraj Kharage <suraj.kharage@enterprisedb.com>,
        tushar <tushar.ahuja@enterprisedb.com>,
        Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        Rushabh Lathia <rushabh.lathia@gmail.com>,
        Tels <nospam-pg-abuse@bloodgate.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        vignesh C <vignesh21@gmail.com>
Subject: Re: backup manifests
In-reply-to: 
 <CA+TgmoYcYc1EoZa2m11goTvJxL9+cJxHprvEnwPZOHDYZOi+KA@mail.gmail.com>
References: 
 <CA+TgmobV+kW5cBCa8_LGvytdOH71gnpqDsmKBR7bghEFgR7Y1w@mail.gmail.com>
 <CA+Tgmob+xDcvEUTznkvianyJzKK8nUM6bWfkrnZQkL-XEa3NEA@mail.gmail.com>
 <20200402172318.3kvfrrewxmemzpia@alap3.anarazel.de>
 <CA+Tgmoa2_8Ti9xez8wEH7Z_RJQv=cwPC=MeqUXcdVW=5-uMCig@mail.gmail.com>
 <20200402182346.6iffoadxu2hsbi2s@alap3.anarazel.de>
 <CA+TgmoboTL8cBt_P5Jx6RjL=Hk3Y8PbpGsh9KcH_MZuswVqdYA@mail.gmail.com>
 <CA+TgmoaGoQM74CMJhqg3_M7osWgkT2xSxo9aGVu9E4Nt+8Z4sg@mail.gmail.com>
 <20200402194750.7ze74b4t6b6o4cui@alap3.anarazel.de>
 <e3101c23-26b7-6fa2-14a8-af24c96602b5@pgmasters.net>
 <CA+TgmoaKhxPr0FWsEiZoXpMER44pMJ28L-Z7wcRrOKoGFwjiUQ@mail.gmail.com>
 <20200403212445.GB12283@telsasoft.com> <31359.1585959529@sss.pgh.pa.us>
 <CA+TgmoYcYc1EoZa2m11goTvJxL9+cJxHprvEnwPZOHDYZOi+KA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Sat, 04 Apr 2020 09:34:52 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11085.1586011431.1@sss.pgh.pa.us>
Date: Sat, 04 Apr 2020 10:43:51 -0400
Message-ID: <11086.1586011431@sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Apr 3, 2020 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I suppose that judicious s/time_t/pg_time_t/ would fix this.

> I think you sent this email just after I pushed
> db1531cae00941bfe4f6321fdef1e1ef355b6bed, or maybe after I'd committed
> it locally and just before I pushed it. If you prefer a different fix
> than what I did there, I can certainly whack it around some more.

Yeah, that commit showed up moments after I sent this.  Your fix
seems fine -- at least prairiedog and gaur are OK with it.
(I did verify that gaur was reproducibly crashing at that new
pg_strftime call, so we know it was that and not some on-again-
off-again issue.)

			regards, tom lane