From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Superuser can permit passwordless connections on
 postgres_fdw
In-reply-to: <20191221021806.GA15758@paquier.xyz>
References: <E1iiBFm-0001RN-N2@gemulon.postgresql.org>
 <20191220120208.GA4258@paquier.xyz> <11297.1576868677@sss.pgh.pa.us>
 <32150.1576870942@sss.pgh.pa.us> <20191221021806.GA15758@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 21 Dec 2019 11:18:06 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11099.1576898240.1@sss.pgh.pa.us>
Date: Fri, 20 Dec 2019 22:17:20 -0500
Message-ID: <11100.1576898240@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Dec 20, 2019 at 02:42:22PM -0500, Tom Lane wrote:
>> I notice in testing this that the "nosuper" business added by
>> 6136e94dc is broken in more ways than what the buildfarm is
>> complaining about: it leaves the role around at the end of the
>> test.

> Roles left behind at the end of a test are annoying.  Here is an idea:
> make pg_regress check if any roles prefixed by "regress_" are left
> behind at the end of a test.  This will not work until test_pg_dump is
> cleaned up, just a thought.

Yeah, it's sort of annoying that the buildfarm didn't notice this
aspect of things.  I'm not sure I want to spend cycles on checking
it in every test run, though.

Maybe we could have -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
enable a check for that aspect along with what it does now?

			regards, tom lane