From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Annoying build warnings from latest Apple toolchain
In-reply-to: <20230928222248.jw6s7yktpfsfczha@alap3.anarazel.de>
References: <467042.1695766998@sss.pgh.pa.us>
 <673900.1695841549@sss.pgh.pa.us> <687188.1695847964@sss.pgh.pa.us>
 <20230928203213.47bn2pv45mkmxtz7@alap3.anarazel.de>
 <1095659.1695933968@sss.pgh.pa.us>
 <20230928222248.jw6s7yktpfsfczha@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 28 Sep 2023 15:22:48 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1111720.1695941929.1@sss.pgh.pa.us>
Date: Thu, 28 Sep 2023 18:58:49 -0400
Message-ID: <1111721.1695941929@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1111721.1695941929%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2023-09-28 16:46:08 -0400, Tom Lane wrote:
>> Well, it's only important on platforms where we can't restrict
>> libpq.so from exporting all symbols.  I don't know how close we are
>> to deciding that such cases are no longer interesting to worry about.
>> Makefile.shlib seems to know how to do it everywhere except Windows,
>> and I imagine we know how to do it over in the MSVC scripts.

> Hm, then I'd argue that we don't need to care about it anymore. The meson
> build does the necessary magic on windows, as do the current msvc scripts.

If we take that argument seriously, then I'm inclined to adjust my
upthread patch for Makefile.global.in so that it removes the extra
inclusions of libpgport/libpgcommon everywhere, not only macOS.
The rationale would be that it's not worth worrying about ABI
stability details on any straggler platforms.

> I think right now it doesn't work as-is on sonoma, because apple decided to
> change the option syntax, which is what causes the -e warning below, so the
> relevant option is just ignored.

Hmm, we'd better fix that then.  Or is it their bug?  It looks to me like
clang's argument is -exported_symbols_list=/path/to/exports.list, so
it must be translating that to "-e".

			regards, tom lane