Message-ID: <111178fd5653becf9e29d9637c37a2c47cf721f2.camel@cybertec.at>
Subject: Re: Regression in COPY FROM caused by 9f8377f7a2
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: pgsql-hackers@lists.postgresql.org
Date: Mon, 25 Sep 2023 10:59:21 +0200
In-Reply-To: <75a7b7483aeb331aa017328d606d568fc715b90d.camel@cybertec.at>
References: <75a7b7483aeb331aa017328d606d568fc715b90d.camel@cybertec.at>
Content-Type: multipart/mixed; boundary="=-8fJaUTSpgh0p8VKWyY//"
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/111178fd5653becf9e29d9637c37a2c47cf721f2.camel%40cybertec.at>
Precedence: bulk

--=-8fJaUTSpgh0p8VKWyY//
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2023-09-25 at 09:54 +0200, Laurenz Albe wrote:
> In v16 and later, the following fails:
>=20
> CREATE TABLE boom (t character varying(5) DEFAULT 'a long string');
>=20
> COPY boom FROM STDIN;
> ERROR:=C2=A0 value too long for type character varying(5)
>=20
> In PostgreSQL v15 and earlier, the COPY statement succeeds.
>=20
> The error is thrown in BeginCopyFrom in line 1578 (HEAD)
>=20
> =C2=A0 defexpr =3D expression_planner(defexpr);
>=20
> Bisecting shows that the regression was introduced by commit 9f8377f7a2,
> which introduced DEFAULT values for COPY FROM.

I suggest the attached fix, which evaluates default values only if
the DEFAULT option was specified or if the column does not appear in
the column list of COPY.

Yours,
Laurenz Albe

--=-8fJaUTSpgh0p8VKWyY//
Content-Disposition: attachment;
	filename="0001-Evaluate-defaults-in-COPY-FROM-only-if-necessary.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
	name="0001-Evaluate-defaults-in-COPY-FROM-only-if-necessary.patch";
	charset="UTF-8"

RnJvbSA0YWY5ODJjNTZkZjU3YTFhMGYwNDM0MGQzOTRjMjk3NTU5ZmJhYmI1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogTW9uLCAyNSBTZXAgMjAyMyAxMDo1NjoxNSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd
IEV2YWx1YXRlIGRlZmF1bHRzIGluIENPUFkgRlJPTSBvbmx5IGlmIG5lY2Vzc2FyeQoKU2luY2Ug
Y29tbWl0IDlmODM3N2Y3YTIsIHdlIGV2YWx1YXRlIHRoZSBjb2x1bW4gZGVmYXVsdCB2YWx1ZXMg
aW4KQ09QWSBGUk9NIGZvciBhbGwgY29sdW1ucyBleGNlcHQgZ2VuZXJhdGVkIG9uZXMsIGJlY2F1
c2UgdGhleSBjb3VsZApiZSBuZWVkZWQgaWYgdGhlIGlucHV0IHZhbHVlIG1hdGNoZXMgdGhlIERF
RkFVTFQgb3B0aW9uLgoKVGhpcyBjYW4gY2F1c2UgYSBzdXJwcmlzaW5nIHJlZ3Jlc3Npb246Cgog
IENSRUFURSBUQUJMRSBib29tICh0IGNoYXJhY3RlciB2YXJ5aW5nKDUpIERFRkFVTFQgJ2EgbG9u
ZyBzdHJpbmcnKTsKICBDT1BZIGJvb20gRlJPTSBTVERJTjsKICBFUlJPUjogIHZhbHVlIHRvbyBs
b25nIGZvciB0eXBlIGNoYXJhY3RlciB2YXJ5aW5nKDUpCgpUaGlzIHdvcmtlZCBiZWZvcmUgOWY4
Mzc3ZjdhMiwgc2luY2UgZGVmYXVsdCB2YWx1ZXMgd2VyZSBvbmx5CmV2YWx1YXRlZCBmb3IgY29s
dW1ucyB0aGF0IHdlcmUgbm90IHNwZWNpZmllZCBpbiB0aGUgY29sdW1uIGxpc3QuCgpUbyBmaXgs
IGZldGNoIHRoZSBkZWZhdWx0IHZhbHVlcyBvbmx5IGlmIHRoZSBERUZBVUxUIG9wdGlvbiB3YXMK
c3BlY2lmaWVkIG9yIGZvciBjb2x1bW5zIG5vdCBzcGVjaWZpZWQgaW4gdGhlIGNvbHVtbiBsaXN0
LgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tLmMgfCA5ICsrKysrKysrLQogMSBm
aWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh
L3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tLmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9j
b3B5ZnJvbS5jCmluZGV4IDcwODcxZWQ4MTkuLjMyMGI3NjRhYTkgMTAwNjQ0Ci0tLSBhL3NyYy9i
YWNrZW5kL2NvbW1hbmRzL2NvcHlmcm9tLmMKKysrIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvY29w
eWZyb20uYwpAQCAtMTU2Nyw3ICsxNTY3LDE0IEBAIEJlZ2luQ29weUZyb20oUGFyc2VTdGF0ZSAq
cHN0YXRlLAogCQkvKiBHZXQgZGVmYXVsdCBpbmZvIGlmIGF2YWlsYWJsZSAqLwogCQlkZWZleHBy
c1thdHRudW0gLSAxXSA9IE5VTEw7CiAKLQkJaWYgKCFhdHQtPmF0dGdlbmVyYXRlZCkKKwkJLyoK
KwkJICogV2UgbmVlZCB0aGUgZGVmYXVsdCB2YWx1ZXMgb25seSBmb3IgY29sdW1ucyB0aGF0IGRv
IG5vdCBhcHBlYXIgaW4gdGhlCisJCSAqIGNvbHVtbiBsaXN0IG9yIGlmIHRoZSBERUZBVUxUIG9w
dGlvbiB3YXMgZ2l2ZW4uICBXZSBhbHNvIGRvbid0IG5lZWQKKwkJICogaXQgZm9yIGdlbmVyYXRl
ZCBjb2x1bW5zLgorCQkgKi8KKwkJaWYgKCghbGlzdF9tZW1iZXJfaW50KGNzdGF0ZS0+YXR0bnVt
bGlzdCwgYXR0bnVtKSB8fAorCQkJIGNzdGF0ZS0+b3B0cy5kZWZhdWx0X3ByaW50ICE9IE5VTEwp
ICYmCisJCQkhYXR0LT5hdHRnZW5lcmF0ZWQpCiAJCXsKIAkJCUV4cHIJICAgKmRlZmV4cHIgPSAo
RXhwciAqKSBidWlsZF9jb2x1bW5fZGVmYXVsdChjc3RhdGUtPnJlbCwKIAkJCQkJCQkJCQkJCQkJ
CQlhdHRudW0pOwotLSAKMi40MS4wCgo=


--=-8fJaUTSpgh0p8VKWyY//--