public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: jian he <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT
Date: Tue, 18 Nov 2025 12:01:19 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxEk34DnJFG72CRsPPT4tsJL9arobX0tNPsn7yH28J=zQg@mail.gmail.com>
References: <CACJufxEk34DnJFG72CRsPPT4tsJL9arobX0tNPsn7yH28J=zQg@mail.gmail.com>

jian he <[email protected]> writes:
> [ v1-0001-IS-JSON-predicate-work-with-domain-type.patch ]

This looks like a large patch with a small patch struggling to
get out of it.  Why didn't you simply do

-	*exprtype = exprType(expr);
+	*exprtype = getBaseType(exprType(expr));

in transformJsonParseArg?

			regards, tom lane





view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: IS JSON predicate support for domain base type as JSON/JSONB/BYTEA/TEXT
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox