From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: John Naylor <john.naylor@enterprisedb.com>,
        Jelte Fennema <Jelte.Fennema@microsoft.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Merlin Moncure <mmoncure@gmail.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>
Subject: Re: [PATCH] Optimize json_lex_string by batching character copying
In-reply-to: <20220711154150.hwzw7qw2k6iahofy@awork3.anarazel.de>
References: 
 <PR3PR83MB0476F098CBCF68AF7A1CA89FF7B49@PR3PR83MB0476.EURPRD83.prod.outlook.com>
 <20220625001810.q4giojmraweoyl5e@alap3.anarazel.de>
 <20220625010551.r5qrk5n2euuwqos3@alap3.anarazel.de>
 <CAFBsxsGhaR2KQ5eisaK=6Vm60t=axhD8Ckj1qFoCH1pktZi+2w@mail.gmail.com>
 <20220706051801.gfbzjxgflbsglyt6@awork3.anarazel.de>
 <CAFBsxsE0FkMT0vZOLfJEOCM1Di81Wy_5fE9S1rn0PNHMYrmCCw@mail.gmail.com>
 <20220711154150.hwzw7qw2k6iahofy@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 11 Jul 2022 08:41:50 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1119851.1657554806.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 11 Jul 2022 11:53:26 -0400
Message-ID: <1119852.1657554806@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1119852.1657554806%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I wonder if we can't abstract this at least a bit better. If we go that =
route
> a bit further, then add another arch, this code will be pretty much
> unreadable.

IMO, it's pretty unreadable *now*, for lack of comments about what it's
doing and why.

			regards, tom lane