public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Oleg Tselebrovskiy <[email protected]>
Cc: [email protected]
Cc: Soumya S Murali <[email protected]>
Subject: Re: 001_password.pl fails with --without-readline
Date: Mon, 19 Jan 2026 14:01:31 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

=?UTF-8?B?T2xlZyBUc2VsZWJyb3Zza2l5?= <[email protected]> writes:
>> While debugging that I got annoyed that a match failure results
>> in a timeout exit with absolutely no data logged about what output
>> the test got.  So v3-0001 also changes timeout() --- which creates
>> a timeout that aborts the test --- to timer() --- which does what
>> the test author clearly expected, namely just stop waiting for
>> more input.  (There's a thread somewhere around here about making
>> that change more globally, but I went ahead and did it here.)

> I've found your thread about this - [1], and I agree, using
> timer() is better here, we get the stdout and stderr of a timed-out
> query

Thanks for digging that up.  After re-reading that thread I'm feeling
nervous about changing timeout() to timer() in something we need to
back-patch, so I'll leave that change out of the committed patch.
We ought to raise the priority of making that happen, though.

> Also, thanks for making both "pump until" blocks identical, it seemed
> a little strange to have them be different.

Yeah, I couldn't see a reason for that either.

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: 001_password.pl fails with --without-readline
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox