From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: Andres Freund <andres@anarazel.de>, David Rowley <dgrowleyml@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
In-reply-to: <1079552.1657549379@sss.pgh.pa.us>
References: <1294462.1656875649@sss.pgh.pa.us>
 <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com>
 <1593978.1656953960@sss.pgh.pa.us>
 <b53b92e0-1153-a31a-8c52-157fa2e07771@enterprisedb.com>
 <2592455.1657140387@sss.pgh.pa.us>
 <b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
 <3302658.1657288366@sss.pgh.pa.us> <611d2e!
 93-6330-47fa-0970-72316aed50f2@enterprisedb.com>
 <3488143.1657310625@sss.pgh.pa.us>
 <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com>
 <20220710214622.haiektrjzisob6rl@awork3.anarazel.de>
 <815831.1657494597@sss.pgh.pa.us>
 <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com>
 <1079552.1657549379@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 11 Jul 2022 10:22:59 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1123939.1657555629.1@sss.pgh.pa.us>
Date: Mon, 11 Jul 2022 12:07:09 -0400
Message-ID: <1123940.1657555629@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1123940.1657555629%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>> could not handle type "ScanDirection" in struct "IndexScan" field 
>> "indexorderdir"

> Ah, I see.  Still, we could also handle that with
> push @enum_types, qw(ScanDirection);

I tried that, and it does work.  The only other input file we could
get rid of that way is nodes/lockoptions.h, which likewise contributes
only a couple of enum type names.  Not sure it's worth messing with
--- both ways seem crufty, though for different reasons.

			regards, tom lane