From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Nancarrow <gregn4422@gmail.com>
cc: vignesh C <vignesh21@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
        Peter Smith <smithpb2250@gmail.com>,
        "Smith,
    Peter" <peters@fast.au.fujitsu.com>,
        David Steele <david@pgmasters.net>,
        "Tsunakawa,
    Takayuki" <tsunakawa.takay@fujitsu.com>,
        Haribabu Kommi <kommi.haribabu@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>,
        Dave Cramer <pg@fastcrypt.com>, Jing Wang <jingwangian@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Elvis Pranskevichus <elprans@gmail.com>
Subject: Re: Libpq support to connect to standby server as priority
In-reply-to: 
 <CAJcOf-fWgXzetSO=ca5K5PbVjqt8QPG4G-+VfFOHM=687mEKkQ@mail.gmail.com>
References: <20201124225917.GA21884@alvherre.pgsql>
 <325979.1606259987@sss.pgh.pa.us> <388250.1606266434@sss.pgh.pa.us>
 <CAJcOf-cgj=bGOZR7F=H+Rg7846ZgC1G+xbkKKLp6zEuOnZeSFQ@mail.gmail.com>
 <493358.1606322607@sss.pgh.pa.us>
 <CAJcOf-emaiiPOgmpxQyAQT=DAOUPPwZ_G7Z70OdD6ZMX2ifCpw@mail.gmail.com>
 <CAJcOf-e-H2VTo_0vuf69Hsh2FS4CxxWzkgDohXDGMr8cCMmurw@mail.gmail.com>
 <3425296.1609882492@sss.pgh.pa.us>
 <CALDaNm0M+70qB=-sXP_-=mu5NSsLC0=QK=0NPfyhZHtMrokEVA@mail.gmail.com>
 <CAJcOf-fgr0QkW+fvfevVcBBJSzPTWHyEJRpvhwDk5ETWxVgGoA@mail.gmail.com>
 <CALDaNm04kMeoXp-HRk2KoKzMaM238=2CO6J6kjPJuziCLorGnQ@mail.gmail.com>
 <CAJcOf-d0NST1ZbEB4-iwapk2y=fKb9xQosbLOf+5j+68C5qMMg@mail.gmail.com>
 <CALDaNm38F070Gs3wYMBBg98iSVUAdsW7YAKfHQ==FoippvbWAA@mail.gmail.com>
 <CAJcOf-fWgXzetSO=ca5K5PbVjqt8QPG4G-+VfFOHM=687mEKkQ@mail.gmail.com>
Comments: In-reply-to Greg Nancarrow <gregn4422@gmail.com>
	message dated "Tue, 16 Feb 2021 16:48:37 +1100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1127613.1614737237.1@sss.pgh.pa.us>
Date: Tue, 02 Mar 2021 21:07:17 -0500
Message-ID: <1127614.1614737237@sss.pgh.pa.us>
Precedence: bulk

Greg Nancarrow <gregn4422@gmail.com> writes:
> I've marked this as "Ready for Committer".

I've pushed this after whacking it around a fair amount.  A lot of
that was cosmetic, but one thing that wasn't is that I got rid of the
proposed "which_primary_host" variable.  I thought the logic around
that was way too messy and probably buggy.  Even if it worked exactly
as intended, I'm dubious that the design intention was good.  I think
it makes more sense just to go through the whole server list again
without the restriction to standby servers.  In particular, that will
give saner results if the servers' status isn't holding still.

			regards, tom lane