From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: pg_upgrade test writes to source directory
In-reply-to: <20220811152028.znxm5fpxjhe43hzw@awork3.anarazel.de>
References: <Yo/5MlXbwY4UhMnm@paquier.xyz> <2464542.1653603596@sss.pgh.pa.us>
 <YpAMBqPrusng47e0@paquier.xyz> <2480063.1653609068@sss.pgh.pa.us>
 <YpAV1y8CUXGGkPJQ@paquier.xyz>
 <20220528195949.tte5fukfr2z6xhrr@alap3.anarazel.de>
 <3131727.1653768841@sss.pgh.pa.us> <YpXA7XHZtunxalTr@paquier.xyz>
 <e65a862a-24aa-7482-6d98-49fbb048f22f@enterprisedb.com>
 <571133.1654095328@sss.pgh.pa.us>
 <20220811152028.znxm5fpxjhe43hzw@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 11 Aug 2022 08:20:28 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11297.1660231599.1@sss.pgh.pa.us>
Date: Thu, 11 Aug 2022 11:26:39 -0400
Message-ID: <11298.1660231599@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/11298.1660231599%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-06-01 10:55:28 -0400, Tom Lane wrote:
>> [...] I'm definitely not happy with the proposed changes to
>> 010_tab_completion.pl.  My recollection is that those tests
>> were intentionally written to test tab completion involving a
>> directory name, but this change just loses that aspect entirely.

> How about creating a dedicated directory for the created files, to maintain
> that? My goal of being able to redirect the test output elsewhere can be
> achieved with just a hunk like this:

Sure, there's no need for these files to be in the exact same place that
the output is collected.  I just want to keep their same relationship
to the test's CWD.

> Of course it'd need a comment adjustment etc. It's a bit ugly to use a
> otherwise empty tmp_check/ directory just to reduce the diff size, but it's
> also not too bad.

Given that it's no longer going to be the same tmp_check dir used
elsewhere, maybe we could s/tmp_check/tab_comp_dir/g or something
like that?  That'd add some clarity I think.

			regards, tom lane