Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gZfNJ-00046O-Lc
	for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Dec 2018 17:11:13 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1gZfNI-0001Ep-9l
	for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Dec 2018 17:11:12 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gZfNH-0001BZ-Ur
	for pgsql-hackers@lists.postgresql.org; Wed, 19 Dec 2018 17:11:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gZfNF-000132-FN
	for pgsql-hackers@postgresql.org; Wed, 19 Dec 2018 17:11:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id wBJHB8dE011308;
	Wed, 19 Dec 2018 12:11:08 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: WRITE_*_ARRAY macros for outfuncs.c
In-reply-to: <8f2ebc67-e75f-9478-f5a5-bbbf090b1f8d@2ndquadrant.com>
References: <8f2ebc67-e75f-9478-f5a5-bbbf090b1f8d@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Tue, 18 Dec 2018 22:12:05 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11306.1545239468.1@sss.pgh.pa.us>
Date: Wed, 19 Dec 2018 12:11:08 -0500
Message-ID: <11307.1545239468@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> In readfuncs.c, we have READ_ATTRNUMBER_ARRAY, READ_OID_ARRAY,
> READ_INT_ARRAY, READ_BOOL_ARRAY, but the writing side in outfuncs.c is
> coded by hand in each case.  Any reason for this?

> Here is a patch that adds WRITE_ATTRNUMBER_ARRAY, WRITE_OID_ARRAY,
> WRITE_INT_ARRAY, WRITE_BOOL_ARRAY.  That seems much nicer.

LGTM.

			regards, tom lane