From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
        amul sul <sul_amul@yahoo.co.in>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Server crash due to SIGBUS(Bus Error) when trying to access the
 memory created using dsm_create().
In-reply-to: <2034.1506365794@sss.pgh.pa.us>
References: <25838.1471010881@sss.pgh.pa.us>
 <CAEepm=24jFz-Bm6awX-U=qfvcxrbQVS1ZU6uUry07r=aGyePgg@mail.gmail.com>
 <CAEepm=1ySPpiPG8hyy98vTGbvi6uXvavsy-zahevkM=tTRUDSQ@mail.gmail.com>
 <CA+TgmoagA8KGfUZzQs8xMTt2rqjw1Ko+vJQV05R=qZz2a98OGQ@mail.gmail.com>
 <CAEepm=0euOKPaYWz0-gFv9xfG+8ptAjhFjiQEX0CCJaYN--sDQ@mail.gmail.com>
 <CA+TgmoYw296PTpQ+iFqcqWECR5x9QW-TE+Rd5Lv9=p0XCxZvOA@mail.gmail.com>
 <CAEepm=27q=VLg5Mh76a1NfzK=9Xi1jnrpYm5VQNbQQJomwhU4A@mail.gmail.com>
 <CA+TgmoY=jMECqMz=RKG3=x=kvMZrf008Ggc4mYNyajqbVkMW4w@mail.gmail.com>
 <CAEepm=3KjgWXAqseQOXxpz4DtkZJ9U5Zcx9hU8iFrVtm5mwFKg@mail.gmail.com>
 <CAEepm=2GAgjcnLGCHOCVTD04eVR+rP+8_-6Z4c391-AFo1sL7g@mail.gmail.com>
 <20170628230458.n5ehizmvhoerr5yq@alap3.anarazel.de>
 <CAEepm=00bvrcNGaHWv7=9F_SE9YKfW1_DuFbAjFh41ycg8mLxw@mail.gmail.com>
 <CAEepm=37ptJz+epr6+iW+O1wCCAxeT04r27Uc8rXmJBoFT2ExA@mail.gmail.com>
 <CAEepm=3b+Wu81XgseDcc_a6JUC6_JCgyj41LGWfY1qto3gE1KA@mail.gmail.com>
 <26247.1506349378@sss.pgh.pa.us> <CA+TgmoY+pXip_OrQdii91iH0UJpL6!
 Z6NTqQ3ETwBj_Chg8jNrg@mail.gmail.com> <488.1506364109@sss.pgh.pa.us>
 <2034.1506365794@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 25 Sep 2017 14:56:34 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11338.1506370389.1@sss.pgh.pa.us>
Date: Mon, 25 Sep 2017 16:13:09 -0400
Message-ID: <11339.1506370389@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

I wrote:
> Rather than dig into the guts of glibc to find that out, though, I think
> we should just s/fallocate/posix_fallocate/g on this patch.  The argument
> for using the former seemed pretty thin to begin with.

Pushed with that change; we'll soon see what the buildfarm thinks.

I suspect that the provisions for EINTR and ENOSYS errors may now be
dead code, since the Linux man page for posix_fallocate mentions
neither.  They're not much code though, and POSIX itself *does*
list EINTR, so I'm hesitant to muck with that.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers