Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbt7q-0002wa-Fs for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 20:48:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hbt7p-0000t0-Ck for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 20:48:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbt7p-0000sp-1R for pgsql-hackers@lists.postgresql.org; Fri, 14 Jun 2019 20:48:41 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbt7m-0000Pp-Os for pgsql-hackers@lists.postgresql.org; Fri, 14 Jun 2019 20:48:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x5EKmZEt011348; Fri, 14 Jun 2019 16:48:35 -0400 From: Tom Lane To: Alvaro Herrera cc: Robert Haas , PostgreSQL Hackers Subject: Re: CREATE STATISTICS documentation bug In-reply-to: <20190614202507.GA3982@alvherre.pgsql> References: <20190614202507.GA3982@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Fri, 14 Jun 2019 16:25:07 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11346.1560545315.1@sss.pgh.pa.us> Date: Fri, 14 Jun 2019 16:48:35 -0400 Message-ID: <11347.1560545315@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > On 2019-Jun-14, Tom Lane wrote: >> Robert Haas writes: >>> P.S. I think the fact that we print "psql: " before the ERROR here is >>> useless clutter. We didn't do that in v11 and prior and I think we >>> should kill it with fire. >> Agreed, particularly seeing that the error is not originating with >> psql; it's just passing it on. > +1 > Proposal: each program declares at startup whether it wants the program > name prefix or not. Well, to clarify: I think it's reasonable to include "psql: " if the message is originating in psql. So I don't think your idea quite does what we want. regards, tom lane