From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: Guillaume Lelarge <guillaume@lelarge.info>,
        Benoit =?iso-8859-1?Q?Lobr=E9au?= <benoit.lobreau@gmail.com>,
        PostgreSQL Developers <pgsql-hackers@postgresql.org>,
        "Dr. Michael Meskes" <michael.meskes@credativ.com>
Subject: Re: Probable memory leak with ECPG and AIX
In-reply-to: <1133632.1656819904@sss.pgh.pa.us>
References: <20211212073411.GA2218865@rfd.leadboat.com>
 <CAPE8EZ4ca2s5tDVHZzQ=iGh+rD8VX5r4Gk8zTTEeh9VaDOMnuQ@mail.gmail.com>
 <CAPE8EZ42eWAemjj58DO0WArCMDG2VYWut38aAGo9V8QH8ETqrg@mail.gmail.com>
 <20220101074055.GA54621@rfd.leadboat.com> <2865639.1641054902@sss.pgh.pa.us>
 <20220102000750.GB54621@rfd.leadboat.com>
 <20220418041645.GA1134228@rfd.leadboat.com> <964681.1656788014@sss.pgh.pa.us>
 <20220703030619.GB2378460@rfd.leadboat.com>
 <1132802.1656819428@sss.pgh.pa.us>
 <20220703034346.GC2378460@rfd.leadboat.com>
 <1133632.1656819904@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 02 Jul 2022 23:45:04 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1135683.1656820798.1@sss.pgh.pa.us>
Date: Sat, 02 Jul 2022 23:59:58 -0400
Message-ID: <1135684.1656820798@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1135684.1656820798%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> On it now, but it'll take a few minutes :-(

Confirmed that either initializing ecpg_clocale or adding -fno-common
allows the ecpglib build to succeed.  (Testing it beyond that would
require another hour or so to build the rest of the system, so I won't.)

As I said, I was already leaning to the idea that initializing the
variable explicitly is better style, so I recommend we do that.

			regards, tom lane