From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>
cc: "movead.li@highgo.ca" <movead.li@highgo.ca>,
        pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: A bug when use get_bit() function for a long bytea string
In-reply-to: 
 <CAG-ACPUbQwpCHhn_KkLAGEc08A91yZhARazj2BGjXvK+eFCVog@mail.gmail.com>
References: <20200312115135445367128@highgo.ca>
 <CAExHW5vUSi4-oPvgMdFWvzuyaTmMtbY=JgdZ+u3T7ZdzQmubig@mail.gmail.com>
 <20200313111842791351178@highgo.ca>
 <CAG-ACPXeQEuvdVBzz+NWgFYoBNwcJfv1W=pJExp4LM_3fgar6w@mail.gmail.com>
 <2020031810480643107833@highgo.ca>
 <CAG-ACPUbQwpCHhn_KkLAGEc08A91yZhARazj2BGjXvK+eFCVog@mail.gmail.com>
Comments: In-reply-to Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>
	message dated "Thu, 26 Mar 2020 19:01:59 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <11356.1585231718.1@sss.pgh.pa.us>
Date: Thu, 26 Mar 2020 10:08:38 -0400
Message-ID: <11357.1585231718@sss.pgh.pa.us>
Precedence: bulk

Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com> writes:
> On Wed, 18 Mar 2020 at 08:18, movead.li@highgo.ca <movead.li@highgo.ca>
> wrote:
>> if we change return type of all those functions to int64, we won't need
>> this cast.
>> I change the 'encode' function, it needs an int64 return type, but keep
>> other
>> functions in 'pg_encoding', because I think it of no necessary reason.

> Ok, let's leave it for a committer to decide.

If I'm grasping the purpose of these correctly, wouldn't Size or size_t
be a more appropriate type?  And I definitely agree with changing all
of these APIs at once, if they're all dealing with the same kind of
value.

			regards, tom lane